Draft
Conversation
- Add docs pseudo module manifests - Add docs pseudo module to on-premises schema and set default values
Member
I think that maybe this is the right time to start implementing the utils module, and use the "real" module (utils) to enable the docs. This requires:
I think that by default the docs should be disabled, or at least with the ingress disabled. Since it's used by admins, I think that for them doing a port forward to read the docs can be enough (we could also add a tip on the furyctl output after the installation). I'm not against depolying everything by default, but maybe as a "production" setting, having them not accessible could be a good idea (to reduce the surface on the intelligence that can be gathered by external actors). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary 💡
Relates:
Note
Opening the PR as draft until I add the missing providers after we decided the open points below.
Description 📝
This PR adds a new
docs"pseudo-module" (all the manifests live here in the distribution repo, there is no actual docs module). This pseudo-module deploys a special build of the docs site, with the documentation for only the version of SD that you are installing.This version of the docs site is build in our docs repository and has working local search.
The docs site will be accessible at an automatically created ingress
docs.<base domain>. The ingress will not be under SSO even if enabled, documentation is publicly accessible anyway.There are some overrides that the user can perform, as per usual, like the ingress host, ingress class and nodeSelector and Tolerations.
Open to discussion:
docspseudo-module the right place for this? Maybe we could have autilsmodule (as we have discussed in the past) and this be a part of it?You can see a version of the site with the following command:
then navigate to localhost:8080
Breaking Changes 💔
None
Tests performed 🧪
Note
All tests have been performed on an on-premises cluster running SD 1.31.1.
Future work 🔧