fix: fetch_owned should not include reserved #649
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reserved triple ids are not assigned to a owner, yet. Including them is inconsistent. There is also a race condition, where a triple is already stored with another owner but `unreserve` has not been called, yet. during that time, a triple will be returned for two different owners. For Presignatures, the owner is known ahead of time. But it is still wrong to assume that all reserved ids will be owned by this node.
Contributor
Author
|
@ChaoticTempest Not quite sure why you included reserved ids in the first place. I might be missing something. But it messes with the fixture generating tests, which read out all owned triples / presignatures of a node and dump them into JSON files. Those JSON files then contain conflicts. |
Contributor
|
it's because of the race condition with state sync. It uses |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reserved triple ids are not assigned to a owner, yet. Including them is inconsistent.
There is also a race condition, where a triple is already stored with another owner but
unreservehas not been called, yet. during that time, a triple will be returned for two different owners.For Presignatures, the owner is known ahead of time. But it is still wrong to assume that all reserved ids will be owned by this node.