feat: store & kick participant from triples and presignature on sync view #371
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChaoticTempest
force-pushed
the
phuong/feat/store-participant-list
branch
from
022aeca to
a4adfa1
Compare
ChaoticTempest
force-pushed
the
phuong/feat/store-participant-list
branch
from
a4adfa1 to
983140c
Compare
volovyks
reviewed
May 19, 2025
jakmeier
previously approved these changes
May 22, 2025
Contributor
jakmeier
left a comment
jakmeier
left a comment
There was a problem hiding this comment.
Looks good to me overall.
@ChaoticTempest do you have a strategy for testing the DB timings and impact of it on overall performance? I'm worried this could make things quite unstable if we run sync too often.
volovyks
previously approved these changes
May 22, 2025
…ore-participant-list
ChaoticTempest
force-pushed
the
phuong/feat/store-participant-list
branch
from
2cc977a to
241c6aa
Compare
volovyks
previously approved these changes
Jun 6, 2025
…ore-participant-list
…ore-participant-list
…ore-participant-list
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds in
*_participantsstorage key where each triple or presignature will store a list of participant at the surface level of redis such that this list can be queried and modified easily.SyncViewis now back such that the owning node will receive a list of triple/presignature shares that the other nodes have. The owning node will then use that info to remove participants from their own list for that particular triple or presignature. This will let future usage of taking of owned protocols to effectively only use those who report they have the shares.This PR however does not implement the part where we utilize this list when taking a protocol from storage, but will be left for another PR instead