Skip to content

PDMA Driver Changes#371

Open
nvgubba wants to merge 2 commits intosifive:masterfrom
nvgubba:sesame_pdma
Open

PDMA Driver Changes#371
nvgubba wants to merge 2 commits intosifive:masterfrom
nvgubba:sesame_pdma

Conversation

@nvgubba
Copy link
Contributor

@nvgubba nvgubba commented Feb 15, 2021

Emmanuel/Bunnaroath can you please help me to review this pull request for the PDMA Drivers

@nvgubba
Copy link
Contributor Author

nvgubba commented Mar 5, 2021

why do we need to increase this value for the DMA driver? increase this value will increase the simulation execution time.

Initially I decreased the value to 300 for Sesame simulation to be faster. By mistake i commited the file, so i reverted it back.
For Sesame i know it is not crossing 300 threshold from DTS so i made it to 300, but if the code is getting used by some other platform it may be more than 300 Interrupt lines. Then the value is not appropriate..so i reverted back to 1024 i.e max interrupts supported by PLIC

Copy link
Contributor

@e-puerto e-puerto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@e-puerto e-puerto added the DNM Do Not Merge label Jun 18, 2021
@e-puerto
Copy link
Contributor

DO NOT MERGE IT until DMA IP is available into Federation release branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

DNM Do Not Merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants