Correct logic for detecting external low frequency clock#247
Open
sctincman wants to merge 1 commit intosifive:masterfrom
Open
Correct logic for detecting external low frequency clock#247sctincman wants to merge 1 commit intosifive:masterfrom
sctincman wants to merge 1 commit intosifive:masterfrom
Conversation
nategraff-sifive
approved these changes
Apr 13, 2020
Contributor
nategraff-sifive
left a comment
nategraff-sifive
left a comment
There was a problem hiding this comment.
Thanks @sctincman!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of a solution to #238, tested on Sifive HiFive1 RevB. Also adds logic for using the LFCLKMUX_SEL register which is active high instead, but as the RevB has the EXT_MUX tied to ground permanently and that mux takes priority, I cannot test that condition.