Skip to content

feat: enabled irsa #373

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
michaeladler merged 1 commit into from
Jan 9, 2026
Merged

feat: enabled irsa #373

michaeladler merged 1 commit into from
Jan 9, 2026
+172 −8

Conversation

@jetendralaha
Copy link

@jetendralaha jetendralaha commented Nov 11, 2025 •
edited
Loading

Description

Please provide a concise summary of the changes and their motivation.

Issues Addressed

List and link all the issues addressed by this PR.

Change Type

Please select the relevant options:

  • Bug fix (non-breaking change that resolves an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist

  • I have read the CONTRIBUTING document.
  • My changes adhere to the established code style, patterns, and best practices.
  • I have added tests that demonstrate the effectiveness of my changes.
  • I have updated the documentation accordingly (if applicable).
  • I have added an entry in the CHANGELOG to document my changes (if applicable).

michaeladler
michaeladler requested changes Nov 19, 2025
View reviewed changes
Copy link
Member

@michaeladler michaeladler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Most CI jobs are failing.
  2. I'd prefer the BeforeConnect callback mechanism (as explained in the other comment).

michaeladler
michaeladler reviewed Nov 20, 2025
View reviewed changes
michaeladler
michaeladler reviewed Nov 21, 2025
View reviewed changes
michaeladler
michaeladler reviewed Nov 21, 2025
View reviewed changes
michaeladler
michaeladler reviewed Nov 21, 2025
View reviewed changes
@jetendralaha jetendralaha force-pushed the rds-enable branch 2 times, most recently from da5de5e to 9dd083c Compare November 25, 2025 16:51
michaeladler
michaeladler reviewed Nov 25, 2025
View reviewed changes
michaeladler
michaeladler requested changes Nov 25, 2025
View reviewed changes
Copy link
Member

@michaeladler michaeladler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This goes into the right direction now. Keep going!

@codecov
Copy link

codecov bot commented Nov 28, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 27.58621% with 42 lines in your changes missing coverage. Please review.
✅ Project coverage is 81.06%. Comparing base (49d3ef8) to head (b2a8869).
⚠️ Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
internal/persistence/entgo/postgres.go 27.58% 39 Missing and 3 partials ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #373      +/-   ##
==========================================
- Coverage   81.82%   81.06%   -0.76%     
==========================================
  Files          93       93              
  Lines        3845     3897      +52     
==========================================
+ Hits         3146     3159      +13     
- Misses        450      488      +38     
- Partials      249      250       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@michaeladler
Copy link
Member

michaeladler commented Nov 28, 2025

The build currently fails due to an outdated go.sum file. Also, please squash all your commits and write a nice git commit message with explanation. Also, an entry to the CHANGELOG.md is missing.

@jetendralaha jetendralaha force-pushed the rds-enable branch 2 times, most recently from 156608a to 08f639a Compare November 29, 2025 03:56
@jetendralaha
Copy link
Author

jetendralaha commented Dec 3, 2025

e build currently fails due to an outdated go.sum file. Also, please squash all your commits and write a nice git commit message with explanation. Also, an entry to the CHANGELOG.md is missing.

fixed as requested..

@michaeladler
Copy link
Member

michaeladler commented Dec 15, 2025

Please check the failing CI jobs. Other than that, I think it looks pretty solid now.

@jetendralaha
Copy link
Author

jetendralaha commented Dec 16, 2025

Please check the failing CI jobs. Other than that, I think it looks pretty solid now.

pipeline seems fine now https://github.com/jetndra/wfx/actions/runs/20260063145/job/58169940284

@michaeladler
Copy link
Member

michaeladler commented Dec 16, 2025

Yeah it does, but now you have to squash your commits again and get rid of the merge commit ;)

@jetendralaha
Copy link
Author

jetendralaha commented Dec 21, 2025 •
edited
Loading

Yeah it does, but now you have to squash your commits again and get rid of the merge commit ;)

fixed now :)

@jetendralaha jetendralaha force-pushed the rds-enable branch 4 times, most recently from cbb6f32 to 7301bd7 Compare December 21, 2025 18:14
@jetendralaha jetendralaha force-pushed the rds-enable branch 2 times, most recently from 09afcfb to 8f7246a Compare December 21, 2025 18:36
@michaeladler
Copy link
Member

michaeladler commented Jan 8, 2026

e build currently fails due to an outdated go.sum file. Also, please squash all your commits and write a nice git commit message with explanation. Also, an entry to the CHANGELOG.md is missing.

fixed as requested..

It looks like you lost the entry to the CHANGELOG.md at some point. I remember it being there but now it's gone.

@jetendralaha
Copy link
Author

jetendralaha commented Jan 8, 2026

e build currently fails due to an outdated go.sum file. Also, please squash all your commits and write a nice git commit message with explanation. Also, an entry to the CHANGELOG.md is missing.

fixed as requested..

It looks like you lost the entry to the CHANGELOG.md at some point. I remember it being there but now it's gone.

Updated CHANGELOG.md

@michaeladler
Copy link
Member

michaeladler commented Jan 8, 2026

Please squash your commits again into a single commit :)

feat: Add AWS RDS IAM authentication for PostgreSQL
b2a8869 
This commit adds support for AWS RDS IAM authentication, allowing the application
to connect to RDS PostgreSQL instances using IAM credentials instead of static passwords.

Key changes:
- Added AWS SDK dependencies for RDS authentication token generation
- Implemented IAM authentication in PostgreSQL connection logic with IRSA support
- Updated configuration documentation with RDS IAM authentication examples
- Added CHANGELOG entry for the new feature

The implementation automatically detects when IAM authentication should be used
based on the connection string and AWS credentials availability.

Signed-off-by: jetendra <jetendra.laha@siemens.com>
@jetendralaha
Copy link
Author

jetendralaha commented Jan 8, 2026

Please squash your commits again into a single commit :)

Please squash your commits again into a single commit :)

please check now..

@michaeladler michaeladler merged commit a6ecb60 into siemens:main Jan 9, 2026
17 checks passed
@michaeladler
Copy link
Member

michaeladler commented Jan 9, 2026

Thanks for your contribution!

@michaeladler michaeladler mentioned this pull request Jan 9, 2026
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stormc stormc Awaiting requested review from stormc stormc is a code owner

@michaeladler michaeladler Awaiting requested review from michaeladler michaeladler is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jetendralaha @michaeladler