Skip to content

fix: replace scss imports with @use#615

Open
Franiac wants to merge 2 commits intosiemens:mainfrom
Franiac:fix/replace-scss-imports
Open

fix: replace scss imports with @use#615
Franiac wants to merge 2 commits intosiemens:mainfrom
Franiac:fix/replace-scss-imports

Conversation

@Franiac
Copy link

@Franiac Franiac commented Feb 5, 2026

What kind of change does this PR introduce? (check one with "x")

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

What is the current behavior? (You can also link to an open issue here)

Issue #613

What is the new behavior?

  • Uses @use instead of @import for scss references
  • Fixed the docs since index.css does not exist anymore

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

@Franiac Franiac requested a review from a team as a code owner February 5, 2026 10:13
@CLAassistant
Copy link

CLAassistant commented Feb 5, 2026

CLA assistant check
All committers have signed the CLA.

@gemini-code-assist
Copy link

Summary of Changes

Hello @Franiac, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request modernizes the project's SCSS codebase by migrating from the deprecated @import rule to the contemporary @use rule. This transition improves stylesheet management by preventing global namespace pollution and enhancing maintainability. Additionally, it updates relevant documentation to reflect these changes and removes references to a no-longer-existing index.css file.

Highlights

  • SCSS Module System Migration: Replaced all instances of the deprecated @import rule with the modern @use rule across various SCSS files, aligning with current Sass module system best practices.
  • Documentation Update: Updated the docs/introduction/themes.md file to reflect the new @use syntax and removed references to the index.css file, which is no longer in use.
  • Removed Obsolete CSS Import: Eliminated imports of index.css from theme files, as this file is no longer necessary for the project's styling.
Changelog
  • docs/introduction/themes.md
    • Updated SCSS code snippets to use @use instead of @import for material.scss and icons.css.
    • Removed the @import '~@siemens/ngx-datatable/index.css'; line.
  • projects/ngx-datatable/src/lib/themes/bootstrap.scss
    • Changed @import './ghost'; to @use './ghost';.
    • Changed @import './rows'; to @use './rows';.
  • projects/ngx-datatable/src/lib/themes/material.scss
    • Updated SCSS code snippets in comments to use @use instead of @import for material.scss and icons.css.
    • Removed the @import '~@siemens/ngx-datatable/index.css'; line from comments.
    • Changed @import './ghost'; to @use './ghost';.
    • Changed @import './rows'; to @use './rows';.
  • src/styles.scss
    • Changed @import '../projects/ngx-datatable/src/lib/themes/material'; to @use '../projects/ngx-datatable/src/lib/themes/material';.
    • Changed @import '../projects/ngx-datatable/src/lib/themes/dark'; to @use '../projects/ngx-datatable/src/lib/themes/dark';.
    • Changed @import '../projects/ngx-datatable/src/lib/themes/bootstrap'; to @use '../projects/ngx-datatable/src/lib/themes/bootstrap';.
Activity
  • No human activity (comments, reviews, etc.) has been recorded on this pull request yet.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request modernizes the SCSS by replacing the @import rule with @use. While this is a good practice for SCSS files, I've noticed that @use has been incorrectly applied to plain CSS files. The @use rule is specifically for Sass files; for CSS files, the standard @import should be used. I've provided suggestions to correct this in the relevant files.

fix: use @import for css references
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants