Skip to content

refactor(demo): remove polyfills from project config#612

Open
chintankavathia wants to merge 1 commit intosiemens:mainfrom
chintankavathia:refactor/polyfills
Open

refactor(demo): remove polyfills from project config#612
chintankavathia wants to merge 1 commit intosiemens:mainfrom
chintankavathia:refactor/polyfills

Conversation

@chintankavathia
Copy link
Member

What kind of change does this PR introduce? (check one with "x")

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

What is the current behavior? (You can also link to an open issue here)

What is the new behavior?

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...

Other information:

@chintankavathia chintankavathia requested a review from a team as a code owner February 4, 2026 09:24
@gemini-code-assist
Copy link

Summary of Changes

Hello @chintankavathia, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on refactoring the project by eliminating the polyfills.ts file and all associated configuration entries. This change streamlines the project setup, likely indicating a shift towards targeting modern browsers that natively support the necessary features, thereby reducing bundle size and simplifying maintenance without introducing any functional or API changes.

Highlights

  • Polyfills Removal: The src/polyfills.ts file has been entirely removed from the project.
  • Configuration Update: The angular.json configuration file was updated to remove the reference to the polyfills.ts file from the build options.
  • TypeScript Configuration: The tsconfig.app.json file was modified to no longer include src/polyfills.ts in its list of files for compilation.
Changelog
  • angular.json
    • Removed the 'polyfills' entry from the build configuration, which previously pointed to 'src/polyfills.ts'.
  • src/polyfills.ts
    • This file, which contained browser and application polyfills for Angular, has been deleted.
  • tsconfig.app.json
    • The reference to 'src/polyfills.ts' was removed from the 'files' array, indicating it is no longer part of the TypeScript compilation.
Activity
  • No human activity (comments, reviews, etc.) has been recorded on this pull request yet.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request effectively removes polyfills from the project configuration, aligning with modern Angular development practices, especially with the adoption of zoneless change detection. The changes are consistent across angular.json, tsconfig.app.json, and the removal of src/polyfills.ts. This refactoring improves maintainability by reducing unnecessary code and configuration overhead.

Copy link
Member

@spike-rabbit spike-rabbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@spike-rabbit spike-rabbit enabled auto-merge (rebase) February 4, 2026 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants