feat(tree): allow specifying key where tree status is saved#130
Open
Killusions wants to merge 1 commit intomainfrom
Open
feat(tree): allow specifying key where tree status is saved#130Killusions wants to merge 1 commit intomainfrom
Killusions wants to merge 1 commit intomainfrom
Conversation
23fde2b to
6005934
Compare
Member
|
I don't think we should do this. This adds more complexity internally and I don't see a need for this. |
Member
Author
|
@spike-rabbit I mean we can argue about allowing recursive keys, but at least specifying the key should be allowed because the datatable should not inform the data structure of the consumer (it also doesn't do this for any of the other functionality). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (check one with "x")
What is the current behavior? (You can also link to an open issue here)
Tree status has to be in the row key "treeStatus", this is suboptimal because it does not allow for separation of UI state and data.
What is the new behavior?
A new input allows specifying a (nested) key to be queried (and updated).
Does this PR introduce a breaking change? (check one with "x")
If this PR contains a breaking change, please describe the impact and migration path for existing applications: ...
Other information: