-
Notifications
You must be signed in to change notification settings - Fork 16
Docs/messaging #153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Docs/messaging #153
Conversation
β Deploy Preview for industrial-experience ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Summary of ChangesHello @ZsuzsannaRacz, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a new documentation file, seemingly as a placeholder or a demonstration. The change is minimal, adding a single file with a basic greeting, indicating an initial step towards potential future documentation efforts related to messaging guidelines. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with π and π on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds a new documentation file, hallo.md, which appears to be a placeholder for a demo. The file's content does not align with the repository's documentation style guide in terms of structure, formatting, tone, or conventions. I have left a detailed comment on the file suggesting a replacement with a properly structured stub that adheres to the project's standards.
| @@ -0,0 +1 @@ | |||
| Hallo UX Writing Team!! No newline at end of file | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file appears to be a placeholder and doesn't adhere to the project's documentation standards. It violates several guidelines from the repository's style guide:
- File Structure: It lacks the required front matter (title, description) and structured content (see style guide lines 36-45).
- Formatting & Tone: The use of
!!and the informal greeting are not aligned with the professional tone of the documentation. The style guide also specifies using sentence case (line 32), soUX Writing Teamshould likely beUX writing team. - Mixed Language: The content mixes German ("Hallo") with English, while the documentation standard is English.
- Missing Newline: The file is missing a newline character at the end, which is a standard convention.
I've suggested a basic structure for a new documentation page that aligns with the project's standards to help you get started.
| Hallo UX Writing Team!! | |
| --- | |
| title: Messaging | |
| description: "Guidelines for user-facing messages." | |
| --- | |
| # Messaging | |
| This section will contain guidelines for messaging. | |
References
- The style guide specifies a mandatory file structure for documentation, which includes a front matter section and a specific ordering of content sections. This file does not follow that structure. (link)
- The style guide requires using sentence case for text, where only the first letter of a sentence and proper nouns are capitalized. (link)
π‘ What is the current behavior?
GitHub Issue Number: #
π What is the new behavior?
Just a demo pull request
π¨βπ» Help & support