Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request addresses a flaky e2e test for the select component by correctly waiting for the dropdown to be visible before taking a snapshot. The changes are effective and directly solve the stability issue. The suggestion to refactor the test code into a loop has been kept as it improves maintainability and does not conflict with any existing rules.
The select has a hover/focus effect which sometimes is flaky. By ensuring the dropdown is actually open before taking snapshot, we can increase stability.
spike-rabbit
force-pushed
the
test/select/flaky-e2e
branch
from
1e56512 to
000e67c
Compare
|
|
|
Documentation. Coverage Reports: |
spliffone
approved these changes
Feb 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The select has a hover/focus effect which sometimes is flaky. By ensuring the dropdown is actually open before taking snapshot, we can increase stability.