refactor(sort-bar): deprecate SiSortBarComponent and SiSortBarModule#1524
refactor(sort-bar): deprecate SiSortBarComponent and SiSortBarModule#1524chintankavathia wants to merge 1 commit intomainfrom
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request correctly deprecates SiSortBarComponent and SiSortBarModule by adding @deprecated JSDoc comments. The reasoning for deprecation is clearly stated. I've suggested a minor grammatical fix in the deprecation messages for improved clarity, reducing the severity to 'low' as it's a minor documentation improvement.
chintankavathia
force-pushed
the
refactor/deprecate/sort-bar
branch
from
601b90a to
b90d3be
Compare
|
Documentation. Coverage Reports: |
chintankavathia
force-pushed
the
refactor/deprecate/sort-bar
branch
2 times, most recently
from
bb48675 to
a3154ac
Compare
spike-rabbit
left a comment
spike-rabbit
left a comment
There was a problem hiding this comment.
Oh yes, we should have done this a long time ago
DEPRECATED: `SiSortBarComponent` and `SiSortBarModule` are deprecated. They originate from the older design system and do not align with current design guidelines. No known use case exists for this component. Both will be removed in v50.
spike-rabbit
force-pushed
the
refactor/deprecate/sort-bar
branch
from
a3154ac to
ccee1b0
Compare
|
This component is used in various projects, we should discuss it and provide a migration strategy instead of simply deprecating the component. |
|
|
spike-rabbit
added
the
discussion
|
@spliffone can you share some screen shots how it is used |
@spike-rabbit yes, it would be super nice to see...so far, i havent seen anyone using this component 🤷 |
Sorry my bad, I mixed it with the |
4 participants
DEPRECATED:
SiSortBarComponentandSiSortBarModuleare deprecated. They originate from the older design system and do not align with current design guidelines. No known use case exists for this component. Both will be removed in v50.