Skip to content

refactor(collapsible-panel): update icon sizes #1504

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
dauriamarco wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

refactor(collapsible-panel): update icon sizes #1504

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ...nel--si-side-panel-collapsible--closed-element-examples-chromium-dark-linux.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
4 changes: 2 additions & 2 deletions ...el--si-side-panel-collapsible--closed-element-examples-chromium-light-linux.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
4 changes: 2 additions & 2 deletions ...panel--si-side-panel-collapsible--open-element-examples-chromium-dark-linux.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
4 changes: 2 additions & 2 deletions ...anel--si-side-panel-collapsible--open-element-examples-chromium-light-linux.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
4 changes: 2 additions & 2 deletions ...snapshots/si-tour--si-tour--first-step-element-examples-chromium-dark-linux.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
4 changes: 2 additions & 2 deletions ...napshots/si-tour--si-tour--first-step-element-examples-chromium-light-linux.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
4 changes: 2 additions & 2 deletions ...-snapshots/si-tour--si-tour--last-step-element-examples-chromium-dark-linux.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
4 changes: 2 additions & 2 deletions ...snapshots/si-tour--si-tour--last-step-element-examples-chromium-light-linux.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
4 changes: 2 additions & 2 deletions ...-snapshots/si-tour--si-tour--open-menu-element-examples-chromium-dark-linux.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
4 changes: 2 additions & 2 deletions ...snapshots/si-tour--si-tour--open-menu-element-examples-chromium-light-linux.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
4 changes: 2 additions & 2 deletions ...napshots/si-tour--si-tour--second-step-element-examples-chromium-dark-linux.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
4 changes: 2 additions & 2 deletions ...apshots/si-tour--si-tour--second-step-element-examples-chromium-light-linux.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
4 changes: 2 additions & 2 deletions ...-accordion--si-collapsible-panel-icons-element-examples-chromium-dark-linux.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
4 changes: 2 additions & 2 deletions ...accordion--si-collapsible-panel-icons-element-examples-chromium-light-linux.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
4 changes: 2 additions & 2 deletions ...bar--si-fixed-height-layout-side-panel-element-examples-chromium-dark-linux.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
4 changes: 2 additions & 2 deletions ...ar--si-fixed-height-layout-side-panel-element-examples-chromium-light-linux.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
7 changes: 6 additions & 1 deletion projects/element-ng/accordion/si-collapsible-panel.component.html
View file
Open in desktop
Copy link
Member Author

@dauriamarco dauriamarco Feb 12, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@panch1739 @hbxes @spike-rabbit continuing the conversation here: I don’t necessarily prefer larger icons in general, but when navbar-vertical and side-panel are shown in the same layout (see screenshots), the size difference is noticeable. Using different icon sizes makes spacing and alignment feel slightly inconsistent.

To me, it feels more coherent if both components use the same sizing and spacing, either small in both cases or large in both, rather than mixing the two. But the final call is yours 👌

With the same size:

Image

With different sizes:

Image Image

Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
[id]="headerId"
[class.open]="opened()"
[class.disabled]="disabled()"
[class.mb-4]="hcollapsed()"
[attr.aria-expanded]="opened() && !hcollapsed()"
[attr.aria-disabled]="disabled()"
[attr.aria-controls]="controlId"
Expand All @@ -16,7 +17,11 @@
>
@let headerIcon = icon();
@if (headerIcon) {
<si-icon class="icon ms-n2 me-2" [icon]="headerIcon" [class.collapsed-icon]="isHCollapsible" />
<si-icon
class="icon-lg ms-n2 me-2"
[icon]="headerIcon"
[class.collapsed-icon]="isHCollapsible"
/>
}
@if (icon() && badge() !== undefined && badge() !== '') {
<span class="badge-text">
Expand Down
4 changes: 2 additions & 2 deletions projects/element-ng/side-panel/si-side-panel-content.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,9 +103,9 @@
[isDisabled]="!isCollapsed()"
[siLink]="dp"
>
<si-icon class="icon" [icon]="dp.icon!" />
<si-icon class="icon-lg" [icon]="dp.icon!" />
@if (dp.overlayIcon) {
<si-icon class="icon position-absolute" [icon]="dp.overlayIcon" />
<si-icon class="icon-lg position-absolute" [icon]="dp.overlayIcon" />
}
<span class="ms-2 auto-hide">{{ dp.title | translate }}</span>
</a>
Expand Down
Loading