chore(element-ng): narrow @siemens/ngx-datatable peer dependency to v25#1498
Draft
chintankavathia wants to merge 1 commit intomainfrom
Draft
chore(element-ng): narrow @siemens/ngx-datatable peer dependency to v25#1498chintankavathia wants to merge 1 commit intomainfrom
chintankavathia wants to merge 1 commit intomainfrom
Conversation
BREAKING CHANGE: Dropped support for @siemens/ngx-datatable versions 22-24. Only version 25 is now supported as a peer dependency.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request correctly narrows the peer dependency for @siemens/ngx-datatable to version 25 in projects/element-ng/package.json. The change is straightforward and aligns with the pull request's title. The inclusion of a BREAKING CHANGE notice in the description is appropriate for dropping support for older versions. The change looks good.
|
|
|
Documentation. Coverage Reports: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: Dropped support for @siemens/ngx-datatable versions 22-24. Only version 25 is now supported as a peer dependency.