Skip to content

refactor(schematics): fix schematics #1483

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
akashsonune wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

refactor(schematics): fix schematics #1483

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions projects/element-ng/schematics/migrations/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,7 @@ export const v47to48Migration = (options: { path: string }): Rule => {
context.logger.info('🚀 Starting migration from v47 to v48...');
const migrationData: ElementMigrationData = getElementMigrationData();
return chain([
elementMigrationRule({ ...options }, migrationData),
missingTranslateMigrationRule(options)
elementMigrationRule({ ...options }, migrationData)
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Feb 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The missingTranslateMigrationRule is being removed from the v47to48Migration, but it is still present in the v48to49Migration. This inconsistency suggests that removing it here might be a mistake. This rule handles important updates to ngx-translate configuration, and its absence could lead to runtime translation issues in applications that are upgraded to v48. This change introduces a potential regression.

      elementMigrationRule({ ...options }, migrationData),
      missingTranslateMigrationRule(options)

])(tree, context);
};
};
Expand Down
Loading