Conversation
panch1739
added
documentation
|
@timowolf whenever you have time, can you review this? |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request effectively restructures the documentation for tables by creating dedicated pages for Bootstrap tables, ngx-datatable, and AG Grid, along with a new overview page. This is a great improvement for clarity and organization. However, the datatable.md file was not fully cleaned up during this refactoring and still contains redundant information about Bootstrap tables and general comparisons. It would be beneficial to remove this legacy content to keep the file focused on ngx-datatable. I've added a few specific comments to address minor issues in the new documentation files.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
| Element provides two different approaches for the implementation of tables and data grids: | ||
|
|
||
| 1. **Bootstrap Table** based on the standard HTML `table` for small tables showing mostly static data | ||
| 2. **Datatable** (`<ngx-datatable>`) for large data sets while supporting various user interactions | ||
|
|
||
| There are various advantages and disadvantages to each approach depending on context and requirements. | ||
| Please check the capabilities and limitations of each approach and make sure to consider both | ||
| architectural as well as UX requirements in your decision. | ||
|
|
||
| Following some constraints and limitations when using the Bootstrap table approach: | ||
|
|
||
| - Header title is not "sticky" to stay on top when using vertical scroll bars | ||
| - Column width cannot be manually resized by the user | ||
| - No pagination support | ||
| - No inherent support for DOM and/or data virtualization as supported by ngx-datatable | ||
| - Performance issues with higher number of rows (>500), but this also depends on DOM complexity and hardware specs |
There was a problem hiding this comment.
We should remove this from here as its already covered above.
2 participants
This PR updates docs to reflect the three different implementation for tables: bootstrap, ngx and ag grid.