Skip to content

feat(buttons): add tooltip support to selection buttons#1426

Open
dauriamarco wants to merge 1 commit intomainfrom
feat/tooltip-selection-buttons
Open

feat(buttons): add tooltip support to selection buttons#1426
dauriamarco wants to merge 1 commit intomainfrom
feat/tooltip-selection-buttons

Conversation

@dauriamarco
Copy link
Member

Adds tooltip support to selection buttons so that they can support tooltips in all configurations both when the label wraps the input/element (text, icon, etc.) and when there’s no wrapping label (using the for attribute).


@dauriamarco dauriamarco added this to the 49.x milestone Feb 3, 2026
@dauriamarco dauriamarco self-assigned this Feb 3, 2026
@dauriamarco dauriamarco requested review from a team as code owners February 3, 2026 11:25
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds tooltip support for selection buttons by overlaying the native input element on top of the styled label. This is a good approach to leverage native browser tooltip behavior. The changes in the SCSS files correctly implement this for cases where the input is wrapped within the label. However, there is an issue with the implementation for sibling input/label elements, where a fixed-width overlay is used, which doesn't work for buttons with variable-width text. I've added a comment with details on this. The changes to the example page and e2e tests are consistent with the new approach.

@github-actions
Copy link

github-actions bot commented Feb 3, 2026

@dauriamarco dauriamarco force-pushed the feat/tooltip-selection-buttons branch from 4f30e54 to deb970e Compare February 4, 2026 11:30
Copy link
Member

@spliffone spliffone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we please add a test case to verify the behaviour, wither vrt or jasmine?

@dauriamarco dauriamarco force-pushed the feat/tooltip-selection-buttons branch from deb970e to 994e2be Compare February 5, 2026 11:31
@dauriamarco dauriamarco force-pushed the feat/tooltip-selection-buttons branch from cb4697a to 617bcef Compare February 6, 2026 10:57
@dauriamarco dauriamarco force-pushed the feat/tooltip-selection-buttons branch from 617bcef to 3f35ec0 Compare February 6, 2026 10:58
@github-actions
Copy link

github-actions bot commented Feb 6, 2026

Code Coverage

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants