feat(buttons): add tooltip support to selection buttons#1426
feat(buttons): add tooltip support to selection buttons#1426dauriamarco wants to merge 1 commit intomainfrom
Conversation
There was a problem hiding this comment.
Code Review
This pull request adds tooltip support for selection buttons by overlaying the native input element on top of the styled label. This is a good approach to leverage native browser tooltip behavior. The changes in the SCSS files correctly implement this for cases where the input is wrapped within the label. However, there is an issue with the implementation for sibling input/label elements, where a fixed-width overlay is used, which doesn't work for buttons with variable-width text. I've added a comment with details on this. The changes to the example page and e2e tests are consistent with the new approach.
projects/element-theme/src/styles/bootstrap/forms/_form-check.scss
Outdated
Show resolved
Hide resolved
|
Documentation. Coverage Reports: |
projects/element-theme/src/styles/bootstrap/forms/_form-check.scss
Outdated
Show resolved
Hide resolved
4f30e54 to
deb970e
Compare
spliffone
left a comment
There was a problem hiding this comment.
Can we please add a test case to verify the behaviour, wither vrt or jasmine?
deb970e to
994e2be
Compare
cb4697a to
617bcef
Compare
617bcef to
3f35ec0
Compare
Adds tooltip support to selection buttons so that they can support tooltips in all configurations both when the label wraps the input/element (text, icon, etc.) and when there’s no wrapping label (using the for attribute).