feat(tooltip): introduce tooltip overlay directive#1379
feat(tooltip): introduce tooltip overlay directive#1379dauriamarco wants to merge 3 commits intomainfrom
Conversation
Summary of ChangesHello @dauriamarco, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a major enhancement to the tooltip system, integrating it more deeply and consistently across various UI components. The changes focus on providing a more dynamic and accessible tooltip experience, complete with animations and intelligent display logic for truncated content. This broadens the utility of tooltips and refines their visual and interactive behavior throughout the application. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request introduces tooltip support to several components, including content-action-bar, collapsible-panel, and tree-view for truncated labels. The implementation is well-done, with nice additions like animations for the tooltip and accessibility improvements by replacing title attributes with aria-label. The refactoring of the siTooltip directive to have fixed triggers (focus and hover) with different delays simplifies its API and aligns with common UX patterns. The updated example page is now much more comprehensive.
I've found one minor issue in a test file regarding a brittle selector, which could be improved for better maintainability.
projects/element-ng/dashboard/widgets/si-list-widget/si-list-widget.component.spec.ts
Outdated
Show resolved
Hide resolved
|
Documentation. Coverage Reports: |
56c2446 to
be359d5
Compare
d20cac9 to
b15d417
Compare
7cd8a71 to
05b488f
Compare
05b488f to
1dec2f5
Compare
Adds support for multiple components.