Open
Conversation
|
Documentation. Coverage Reports: |
dauriamarco
force-pushed
the
docs/improve-buttons-examples
branch
3 times, most recently
from
1ad8334 to
e0e8f09
Compare
dauriamarco
commented
Jan 8, 2026
dauriamarco
force-pushed
the
docs/improve-buttons-examples
branch
2 times, most recently
from
13efd16 to
d74f0a6
Compare
1 task
dauriamarco
requested review from
a team,
dr-itz and
spliffone
as code owners
dauriamarco
force-pushed
the
docs/improve-buttons-examples
branch
from
d74f0a6 to
7eea157
Compare
dauriamarco
changed the title
panch1739
reviewed
Jan 20, 2026
Member
panch1739
left a comment
panch1739
left a comment
There was a problem hiding this comment.
@dauriamarco It looks good for me, but i have one note...the icons inside the buttons should not be the filled version. In our design system, filled version of icons are used for emphasis or to represent that the icon is active.
dauriamarco
force-pushed
the
docs/improve-buttons-examples
branch
from
7eea157 to
9eb91b6
Compare
panch1739
reviewed
Jan 29, 2026
Member
panch1739
left a comment
panch1739
left a comment
There was a problem hiding this comment.
@dauriamarco I found only one thing:
Button group, icon-only version: Button width should be also 40px instead of 32px
All the rest looks good! Thank youuu
dauriamarco
force-pushed
the
docs/improve-buttons-examples
branch
4 times, most recently
from
6af2284 to
c128836
Compare
panch1739
reviewed
Feb 9, 2026
Member
panch1739
left a comment
panch1739
left a comment
There was a problem hiding this comment.
@dauriamarco Heyyy all good, i just found one thing. In the button group example, the small size version of the icon button, is 32x24px. It should be 24px by 24px, making them square
dauriamarco
force-pushed
the
docs/improve-buttons-examples
branch
from
c128836 to
d2cae03
Compare
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates and improves all buttons examples including
buttoncategoriesaccording to the newbtn-iconspecs.