Skip to content

fix: allow npm package to be installed with any engine#11

Merged
spike-rabbit merged 1 commit intomainfrom
fix/package/allow-yarn
Feb 9, 2026
Merged

fix: allow npm package to be installed with any engine#11
spike-rabbit merged 1 commit intomainfrom
fix/package/allow-yarn

Conversation

@chintankavathia
Copy link
Member

@chintankavathia chintankavathia commented Feb 9, 2026

currently it is not possible to install this package if application is using yarn engine.

@gemini-code-assist
Copy link

Summary of Changes

Hello @chintankavathia, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves an installation incompatibility issue for consumers using yarn by removing a restrictive engine constraint from the package.json. While enhancing external compatibility, it maintains internal development consistency by introducing a preinstall script that mandates npm for dependency management within the repository itself.

Highlights

  • Engine Restriction Removal: The explicit yarn engine restriction has been removed from the package.json file, allowing the package to be installed by applications using yarn or other package managers.
  • Development Environment Enforcement: A preinstall script has been added to package.json to enforce the use of npm for dependency installation within the repository during development, ensuring consistency for contributors.
Changelog
  • package.json
    • Removed the yarn entry from the engines field, which previously prevented installation with yarn.
    • Added a preinstall script (npx -y only-allow npm) to ensure that npm is used for dependency installation during development.
Activity
  • No human activity has been recorded on this pull request yet.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request aims to allow consumers to install the package using package managers other than npm, like yarn. It does this by removing the engines.yarn restriction and adding a preinstall script to enforce npm for development. However, the preinstall script will also run for consumers, effectively blocking them from using other package managers, which defeats the purpose of this change. My review includes a critical comment with a suggested fix to ensure the preinstall script only runs in the development environment.

@chintankavathia chintankavathia marked this pull request as ready for review February 9, 2026 06:13
@chintankavathia chintankavathia requested a review from a team as a code owner February 9, 2026 06:13
Copy link
Member

@spike-rabbit spike-rabbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@spike-rabbit spike-rabbit merged commit cf23686 into main Feb 9, 2026
2 checks passed
@spike-rabbit spike-rabbit deleted the fix/package/allow-yarn branch February 9, 2026 07:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants