fix: allow npm package to be installed with any engine#11
Conversation
Summary of ChangesHello @chintankavathia, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request resolves an installation incompatibility issue for consumers using Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request aims to allow consumers to install the package using package managers other than npm, like yarn. It does this by removing the engines.yarn restriction and adding a preinstall script to enforce npm for development. However, the preinstall script will also run for consumers, effectively blocking them from using other package managers, which defeats the purpose of this change. My review includes a critical comment with a suggested fix to ensure the preinstall script only runs in the development environment.
d32a172 to
a51415d
Compare
currently it is not possible to install this package if application is using yarn engine.