Skip to content

Conversation

@Kriplingo
Copy link
Collaborator

Created a subdirectory for single-shot benchmarking with adjusted encodings and automated single-shot benchmarking script.

Copy link
Collaborator

@rtaupe rtaupe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please suggest a reorganization of the directory structure in which the current contents of the singleshot_bench directory are in a subdirectory of benchmarks.
And then let's do a peer review of your pull request face-to-face.
Thank you!

Copy link
Collaborator

@rtaupe rtaupe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please address the below comments and separate the generation of BM instances and the running of the BMs into two separate scripts. Thank you!

ELEMENT_TYPES = 4
ELEMENT_NAMES = 'ABCD'

domain_sizes = [19, 33, 51, 65, 84, 98, 116, 130, 149, 163, 181, 195, 214, 228, 246, 260, 279, 293, 311, 325]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add some documentation

@@ -0,0 +1,9 @@
#include "ooasp.lp".
#include "ooasp_symmetry.lp".
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For better comparability, please keep #include statements that already exist in ooasp.lp there, and only add includes here that do not exist in the multi-shot version of ooasp.lp

Comment on lines +30 to +31
:- user(ooasp_isa(C,new_object)),
not ooasp_isa(C,new_object). No newline at end of file
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be removed

@@ -0,0 +1,23 @@
% Copyright (c) 2022 Siemens AG Oesterreich
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

File not used (?), please remove

@rtaupe rtaupe marked this pull request as draft August 13, 2024 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants