-
Notifications
You must be signed in to change notification settings - Fork 1
Single-shot solving benchmarks implementation #56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
rtaupe
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please suggest a reorganization of the directory structure in which the current contents of the singleshot_bench directory are in a subdirectory of benchmarks.
And then let's do a peer review of your pull request face-to-face.
Thank you!
…ingleshot_cleaned
rtaupe
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please address the below comments and separate the generation of BM instances and the running of the BMs into two separate scripts. Thank you!
benchmarks/singleshot/autorun.py
Outdated
| ELEMENT_TYPES = 4 | ||
| ELEMENT_NAMES = 'ABCD' | ||
|
|
||
| domain_sizes = [19, 33, 51, 65, 84, 98, 116, 130, 149, 163, 181, 195, 214, 228, 246, 260, 279, 293, 311, 325] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add some documentation
| @@ -0,0 +1,9 @@ | |||
| #include "ooasp.lp". | |||
| #include "ooasp_symmetry.lp". | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For better comparability, please keep #include statements that already exist in ooasp.lp there, and only add includes here that do not exist in the multi-shot version of ooasp.lp
| :- user(ooasp_isa(C,new_object)), | ||
| not ooasp_isa(C,new_object). No newline at end of file |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should be removed
| @@ -0,0 +1,23 @@ | |||
| % Copyright (c) 2022 Siemens AG Oesterreich | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
File not used (?), please remove
Created a subdirectory for single-shot benchmarking with adjusted encodings and automated single-shot benchmarking script.