Skip to content

Conversation

@sercanpekel
Copy link

@sercanpekel sercanpekel commented Feb 17, 2022

Thanks for a great package. I was curious if the usdm features would work in the coinm futures. Just changing the api address makes it possible to work with coin-m api as well.

I am new to package building and github, so I apologize in advance if I have taken a misstep here.

In sending an order in one-way mode, the positionSide argument should be "BOTH". Otherwise, it keeps getting an error code 4061 POSITION_SIDE_NOT_MATCH. In the latest commit, I added the "BOTH" argument to the binance.R. As far as I checked, it works the same way in the USDM futures. So, this commit (28a5d12) may be beneficial in the one-way mode new order in USDM API as well.

The other commits are api address changes and should be dismissed; however, I couldn't delete them and only send the last commit.

@sercanpekel sercanpekel marked this pull request as ready for review February 17, 2022 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant