Open
Conversation
This CL includes only HoverProvider tests, that use the same scenario as the hover provider tests with godoc and gogetdoc in integration/extension.test.ts. Gopls test setup is complicated because gopls currently does not work in a single-file mode nor support mono repos with multiple modules. VS Code in test environment does not support dynamic registration of workspace folders during testing. So, the workspace folder needs to be specified before the extension host launches (by vscode-test.runTests or launch.json extensionHost type tasks). As a workaround, I use an empty directory and start the extension host with the empty directory for a testing. Then, let the test populate the directory with necessary files. This is not ideal; file copy is slow and the use of the single workspace directory prevents parallelized testing. Commiting an empty directory to use as a scratch space is not ideal either, but no worse than what vscode dev in my opinion. https://github.com/microsoft/vscode/blob/master/.vscode/launch.json I also considered shelling out the extension host launch after creating a temp directory and using it as a workspace directory. That may work inside test/runTest.ts, but complicates debugging when sarting the test using launch.json. Also passes '--user-data-dir' flag to prevent the tests from using my personal vscode settings and interfere tests. Change-Id: I7b064441720da5c89833afab35e8273de808cfad
* goImports: avoid collapsing new imports into pseudo import line getTextEditForAddImport tries to insert a newly added package into an existing import group. If no import group exists, it tries to merge single line import statements and create a group. In this process, import statements like import "C" are pseudo imports and shouldn't be grouped with other imports. This CL changes parseFilePrelude to detect such pseudo imports and excludes such imports from the grouping logic. Fixes #1701 * correct the file name mac and vsccode ignored casing, but linux and git were unhappy.
The lint rule was changed since PR #3157 so the newly added code broke the lint test. Change-Id: Ic58dfa62e19cb61600b45fe10b43811eb00bc28d Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/230297 Reviewed-by: Rebecca Stambler <rstambler@golang.org>
Change-Id: I38114cf28e5b0151266b0a0b62cd3ef9f85c7361
Change-Id: Ic1a6eb955ad9a2e4eab81771dd0c4471670e22fa
s/License.txt/LICENSE
sidradchandran
added
accepted
hacktoberfest
hacktoberfest-accepted
and removed
accepted
hacktoberfest
labels
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
19 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.