chore: complete cronsnap cleanup and adapter hardening#8
Open
chore: complete cronsnap cleanup and adapter hardening#8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR completes the cleanup checklist against origin main, including runtime adapter refactor, command split, wrapper hardening, doc/spec cleanup, and CI gate expansion.
Scope completed
cronsnap gatecommand and updated wrapper enforcement path:/Users/sidmohan/Projects/cronsnap/cmd/cronsnap/cmd_gate.go/Users/sidmohan/Projects/cronsnap/scripts/adapters/_common.sh/Users/sidmohan/Projects/cronsnap/scripts/adapters/cronsnap-git-wrapper.sh/Users/sidmohan/Projects/cronsnap/scripts/adapters/cronsnap-gh-wrapper.sh/Users/sidmohan/Projects/cronsnap/scripts/adapters/cronsnap-gog-wrapper.sh/Users/sidmohan/Projects/cronsnap/cmd/cronsnap/shim.go/Users/sidmohan/Projects/cronsnap/cmd/cronsnap/cmd_gate.go/Users/sidmohan/Projects/cronsnap/cmd/cronsnap/cmd_hooks.go/Users/sidmohan/Projects/cronsnap/cmd/cronsnap/cmd_doctor.go/Users/sidmohan/Projects/cronsnap/cmd/cronsnap/cmd_init_onboard.go/Users/sidmohan/Projects/cronsnap/cmd/cronsnap/cmd_run.go/Users/sidmohan/Projects/cronsnap/cmd/cronsnap/cmd_status.go/Users/sidmohan/Projects/cronsnap/cmd/cronsnap/main_test.go/Users/sidmohan/Projects/cronsnap/scripts/ci/cs-gh-wrapper-smoke.sh/Users/sidmohan/Projects/cronsnap/scripts/ci/cs-gog-wrapper-smoke.sh/Users/sidmohan/Projects/cronsnap/scripts/ci/cs-git-wrapper-smoke.shhe-*scripts and updated lint/doc registrations./Users/sidmohan/Projects/cronsnap/docs/plans/tech-debt-tracker.md/Users/sidmohan/Projects/cronsnap/docs/FRONTEND.md(removed)/Users/sidmohan/Projects/cronsnap/docs/DOMAIN_DOCS.md/Users/sidmohan/Projects/cronsnap/scripts/ci/cs-docs-config.jsonValidation
go vet ./...go test ./...staticcheck ./...(golangci-lint not installed in env)bash scripts/ci/cs-plans-lint.shbash scripts/ci/cs-spikes-lint.shbash scripts/ci/cs-specs-lint.shbash scripts/ci/cs-docs-lint.shbash scripts/ci/cs-runbooks-lint.shbash scripts/ci/cs-git-wrapper-smoke.shbash scripts/ci/cs-gh-wrapper-smoke.shbash scripts/ci/cs-gog-wrapper-smoke.shgo test ./cmd/cronsnap -run 'TestCanJSON|TestStatusJSON|TestHooksEnable|TestCreate...'Notes
cs-docs-lintstill reported one pre-existing warning indocs/design-docs/core-beliefs.md; this PR replaces seed placeholders to remove that warning.