Skip to content

chore: complete cronsnap cleanup and adapter hardening#8

Open
sidmohan0 wants to merge 1 commit intomainfrom
codex/cleanup-cronsnap-taskplan
Open

chore: complete cronsnap cleanup and adapter hardening#8
sidmohan0 wants to merge 1 commit intomainfrom
codex/cleanup-cronsnap-taskplan

Conversation

@sidmohan0
Copy link
Owner

Summary

This PR completes the cleanup checklist against origin main, including runtime adapter refactor, command split, wrapper hardening, doc/spec cleanup, and CI gate expansion.

Scope completed

  • Added cronsnap gate command and updated wrapper enforcement path:
    • /Users/sidmohan/Projects/cronsnap/cmd/cronsnap/cmd_gate.go
    • /Users/sidmohan/Projects/cronsnap/scripts/adapters/_common.sh
    • /Users/sidmohan/Projects/cronsnap/scripts/adapters/cronsnap-git-wrapper.sh
    • /Users/sidmohan/Projects/cronsnap/scripts/adapters/cronsnap-gh-wrapper.sh
    • /Users/sidmohan/Projects/cronsnap/scripts/adapters/cronsnap-gog-wrapper.sh
  • Consolidated shim logic via shared helper:
    • /Users/sidmohan/Projects/cronsnap/cmd/cronsnap/shim.go
  • Split command handlers for reviewability:
    • /Users/sidmohan/Projects/cronsnap/cmd/cronsnap/cmd_gate.go
    • /Users/sidmohan/Projects/cronsnap/cmd/cronsnap/cmd_hooks.go
    • /Users/sidmohan/Projects/cronsnap/cmd/cronsnap/cmd_doctor.go
    • /Users/sidmohan/Projects/cronsnap/cmd/cronsnap/cmd_init_onboard.go
    • /Users/sidmohan/Projects/cronsnap/cmd/cronsnap/cmd_run.go
    • /Users/sidmohan/Projects/cronsnap/cmd/cronsnap/cmd_status.go
  • Added/expanded tests:
    • /Users/sidmohan/Projects/cronsnap/cmd/cronsnap/main_test.go
  • Added dedicated wrapper smoke checks:
    • /Users/sidmohan/Projects/cronsnap/scripts/ci/cs-gh-wrapper-smoke.sh
    • /Users/sidmohan/Projects/cronsnap/scripts/ci/cs-gog-wrapper-smoke.sh
    • expanded /Users/sidmohan/Projects/cronsnap/scripts/ci/cs-git-wrapper-smoke.sh
  • Removed legacy he-* scripts and updated lint/doc registrations.
  • Archived completed plans under docs/plans/completed and updated tracker in:
    • /Users/sidmohan/Projects/cronsnap/docs/plans/tech-debt-tracker.md
  • Removed stale/deleted docs and updated domain/docs indexes:
    • /Users/sidmohan/Projects/cronsnap/docs/FRONTEND.md (removed)
    • /Users/sidmohan/Projects/cronsnap/docs/DOMAIN_DOCS.md
    • /Users/sidmohan/Projects/cronsnap/scripts/ci/cs-docs-config.json
  • Updated root docs and README for gate/wrapper behavior and machine-readable payloads.

Validation

  • go vet ./...
  • go test ./...
  • staticcheck ./... (golangci-lint not installed in env)
  • bash scripts/ci/cs-plans-lint.sh
  • bash scripts/ci/cs-spikes-lint.sh
  • bash scripts/ci/cs-specs-lint.sh
  • bash scripts/ci/cs-docs-lint.sh
  • bash scripts/ci/cs-runbooks-lint.sh
  • bash scripts/ci/cs-git-wrapper-smoke.sh
  • bash scripts/ci/cs-gh-wrapper-smoke.sh
  • bash scripts/ci/cs-gog-wrapper-smoke.sh
  • go test ./cmd/cronsnap -run 'TestCanJSON|TestStatusJSON|TestHooksEnable|TestCreate...'

Notes

  • cs-docs-lint still reported one pre-existing warning in docs/design-docs/core-beliefs.md; this PR replaces seed placeholders to remove that warning.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants