Added possibility to add/remove ingredients to/from recipe#11
Open
sidlauskaslukas wants to merge 1 commit intomasterfrom
Open
Added possibility to add/remove ingredients to/from recipe#11sidlauskaslukas wants to merge 1 commit intomasterfrom
sidlauskaslukas wants to merge 1 commit intomasterfrom
Conversation
Edmu
reviewed
Aug 31, 2017
| this.nav.pop(); | ||
| } | ||
|
|
||
| addIngredient() { |
Collaborator
There was a problem hiding this comment.
Maybe openAddIngredient or navAddIngredient would suit better.
Edmu
reviewed
Aug 31, 2017
| addIngredient() { | ||
| let addIngredientModal = this.modalCtrl.create(AddIngredientPage, {recipeTitle: this.recipe.name}); | ||
| addIngredientModal.onDidDismiss(ingredient => { | ||
| if(ingredient) this.recipe.ingredients.push({id: ingredient.id, amount: 40}); |
Collaborator
There was a problem hiding this comment.
Moving onDidDismiss handler logic to class method and calling it from arrow function would be cleaner. Also hardcoded amount (40) could be changed to class attribute defaultNewIngredientAmount or something like that.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.