Skip to content

Logout(): Resting current/sessionToken before throwing exception #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ahmedengu wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Logout(): Resting current/sessionToken before throwing exception #30

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/com/parse4cn1/ParseUser.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -320,11 +320,11 @@ public void logout() throws ParseException {
ParseCommand command = new ParsePostCommand(ENDPOINT_LOGOUT);
command.addHeader(ParseConstants.HEADER_SESSION_TOKEN, getSessionToken());
ParseResponse response = command.perform();
setSessionToken(null);
Copy link
Owner

@sidiabale sidiabale Apr 19, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ahmedengu Why would it make more sense to reset the session and current user before checking whether the action succeeded. In my opinion the original implementation makes more sense i.e. resetting only after a successful deletion

current = null;
if (response.isFailed()) {
throw response.getException();
}
setSessionToken(null);
current = null;
}
}

Expand Down