New class MwnWikitextAST for better parsing #94
Conversation
|
Will close #93 |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
|
||
| it('unbinds and rebinds text', function () { | ||
| let u = new bot.WikitextAST('Hello world <!-- world --> world'); | ||
| u.unbind('<!--', '-->'); |
Check failure
Code scanning / CodeQL
Bad HTML filtering regexp High test
|
|
||
| // with multiple unbinds: | ||
| u = new bot.WikitextAST('Hello <nowiki>world</nowiki> <!-- world --> world'); | ||
| u.unbind('<!--', '-->'); |
Check failure
Code scanning / CodeQL
Bad HTML filtering regexp High test
|
wikiparser-node requires node>=18.17.0 |
|
@siddharthvp Hi! May I know if you will have time to take a look at this PR? The CodeQL failure is false positive, and the Node.js CI failure is due to the incompatible requirement (wikiparser-node requires node>=18.17.0). I do not have access to the snyk failure. |
|
Sorry for ignoring this PR. While this is very interesting, from a documentation standpoint it makes things murky to have essentially two ways to do the same thing (parsing wikitext). So, I need to think more about how to cleanly integrate this, which would probably involve removing the current non-AST class altogether. |
Please take your time! Just FYI, this was your previous comment. |
2 participants
The new class MwnWikitextAST provides async parsing based on wikiparser-node@1.22.0.