Fix support for models with custom objective functions (Issue #92)#93
Draft
Fix support for models with custom objective functions (Issue #92)#93
Conversation
- Make 'objective' key nullable in scanner.py - Handle missing objective in parser.py - Add test for custom objective model support 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #92
Summary
objective=line is missing from the model fileChanges Made
lleaves/compiler/ast/scanner.pyto make the 'objective' key nullable by addingnull_ok=Truelleaves/compiler/ast/parser.pyto handle cases where the objective is not present in the scanned modeltest_custom_objectiveto verify custom objective supportTest plan
🤖 Generated with Claude Code