Skip to content

Find group#176

Open
yajaneya wants to merge 7 commits intosiblis:developfrom
yajaneya:findGroup
Open

Find group#176
yajaneya wants to merge 7 commits intosiblis:developfrom
yajaneya:findGroup

Conversation

@yajaneya
Copy link

@PaLoMaster PaLoMaster changed the base branch from master to develop May 24, 2019 08:38
Copy link
Collaborator

@PaLoMaster PaLoMaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Предлагаю доделать... :)

ClientController cc;

GroupController(ClientController cc) {
public GroupController(ClientController cc) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Не надо. Обращаемся через ClientController...

}
}

public Group findGroup (String name) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

... У этого метода убери public и сделай публичный в ClienController, из которого и запускай данный метод GroupController'а.

}

public Group findGroup (String name) {
Group group = new Group();
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Группу (с её информацией) надо получить с сервера...

@FXML
public void findContact(KeyEvent keyEvent) {
if (chats.isSelected()) {
groupSearchListView.getItems().clear();
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

А не может быть случая groupSearchListView == null...? ;)

User us = new User();
us.setId(findGroup.getGid());
us.setUserName(findGroup.getGroup_name());
temp.setUser(us);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Может быть сразу сделаем без этого костыля...?))

Copy link
Collaborator

@PaLoMaster PaLoMaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

И в слаке ещё один вопрос (по 781ой строке ChatViewController)...

try {
ServerResponse response = HTTPSRequest.getGroupInfo(groupName, token);

ServerResponse response = HTTPSRequest.getGroupInfo(groupId, token);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Это старый метод. Надо реализовать по аналогии со строкой 78.


public static ServerResponse getGroupInfo(String id, String token) throws Exception {
HttpsURLConnection connection = getConnection("/v1/chats/" + id, "GET", token);
HttpsURLConnection connection = getConnection("/groups/%id=" + id, "GET", token);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Это к старому бэкенду был. Сейчас переделываем и этот метод надо будет удалить.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants