Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6c58ff7174
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| - name: Add Environment variables | ||
| run: | | ||
| echo "GNU_BISON_BIN=C:\tools\cygwin\bin\bison.exe" >> $env:GITHUB_ENV | ||
| echo "GNU_FLEX_BIN=C:\tools\cygwin\bin\flex.exe" >> $env:GITHUB_ENV | ||
| echo "PYTHON_BIN=C:\tools\cygwin\bin\python3.9.exe" >> $env:GITHUB_ENV |
There was a problem hiding this comment.
Avoid hardcoding Cygwin Python minor version
The workflow hardcodes C:\tools\cygwin\bin\python3.9.exe, but the Cygwin python3 package’s executable name changes when the minor version updates (e.g., python3.10.exe, python3.11.exe). On runners where 3.9 is no longer present, the Version.py step will fail and the release ZIP won’t be produced. Using the unversioned python3.exe (or relying on PATH) would avoid this fragility.
Useful? React with 👍 / 👎.
Motivation
Win64/Mana.exe, therunnerdirectory, andLICENSE.mdfor distribution.Description
.github/workflows/release_windows_zip.ymlthat triggers onpushof tags and setspermissions: contents: write.msbuildand Cygwin, exports required env variables, checks out the repo, runsVersion.py, and builds the x64 Release withmsbuild mana.sln /t:build /p:Configuration=Release /p:Platform=x64.release-stagedirectory, copiesx64/Release/mana.exetoWin64/Mana.exe, copies the entirerunnerdirectory andLICENSE.md, compresses the stage intoMana-Windows-Release.zipin$env:RUNNER_TEMP, and writesZIP_PATHto the environment.softprops/action-gh-release@v1.Testing
Codex Task