[ISSUE-19] feature: allow configuring maxMarkers #86
+10
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
KrenTrox
reviewed
Dec 23, 2024
KrenTrox
reviewed
Dec 23, 2024
src/index.js
Outdated
| } | ||
| if (state[OPT_MARKERS] !== undefined) { | ||
| uniforms[GLSLX_NAME_MARKERS].value = mapMarkers(state[OPT_MARKERS]) | ||
| uniforms[GLSLX_NAME_MARKERS].value = mapMarkers(state[OPT_MARKERS], opts[OPT_MAX_MARKERS] || 64) |
There was a problem hiding this comment.
I think that 64 should be extracted into a const.
Co-authored-by: Shlomi Sela <33803648+KrenTrox@users.noreply.github.com>
KrenTrox
reviewed
Dec 24, 2024
Co-authored-by: Shlomi Sela <33803648+KrenTrox@users.noreply.github.com>
KrenTrox
approved these changes
Dec 25, 2024
|
@shuding wdyt? |
Owner
|
I think if we really want to render a lot more markers by sacrificing the performance (4-5x slower), we can just change 64 to 300 without an extra config. I'm ok with that with a warning in dev. The reason that there's this limitation is you should not really do that, or this library itself needs significant improvements (I mentioned in other comments). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#19
We increase the baked in maximum to 300.
Then through options we allow overriding (0-300), with 64 being the default if not provided.