Python change #1
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bantosik
reviewed
Nov 3, 2023
app.py
Outdated
| def __init__(self, name, location, availabilities, price): | ||
| self.name = name | ||
|
|
||
| class User: |
Collaborator
There was a problem hiding this comment.
Let's not add baseclass for User yet. There is a powerful rule in programming: YAGNI.
https://en.wikipedia.org/wiki/You_aren%27t_gonna_need_it
Owner
Author
|
ok!
________________________________
From: bantosik ***@***.***>
Sent: Friday, November 3, 2023 5:08 PM
To: shu1513/opentango ***@***.***>
Cc: shu1513 ***@***.***>; Author ***@***.***>
Subject: Re: [shu1513/opentango] Python change (PR #1)
@bantosik commented on this pull request.
________________________________
In app.py<#1 (comment)>:
def to_json(self):
return {"start": self.start, "end": self.end}
…-class Teacher:
- def __init__(self, name, location, availabilities, price):
- self.name = name
+
+class User:
Let's not add baseclass for User yet. There is a powerful rule in programming: YAGNI.
https://en.wikipedia.org/wiki/You_aren%27t_gonna_need_it
—
Reply to this email directly, view it on GitHub<#1 (review)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ADI3CELLTHAQ7LLQCRV4JPDYCUQHJAVCNFSM6AAAAAA64USSMSVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTOMJTGE3TMNBRGI>.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.