Skip to content

Conversation

@reversi-fun
Copy link

By stopping the retention of the coordinates of the figure, it became possible to draw larger spectre figures faster.

@shrx
Copy link
Owner

shrx commented Feb 5, 2024

Hello @reversi-fun, thank you for your contribution. It will take me a couple of days to review the pull request, but looks good at first glance. Just a couple of suggestions:

  • I would remove the matplotlib code, since you already established that drawsvg provides better performance;
  • I would remove the 6 MB spectre_tile7.3-12.7_5-34649useRef.svg rendering as it will create quite some overhead for subsequent commits.

@reversi-fun
Copy link
Author

reversi-fun commented Feb 5, 2024

Hi @shrx,
These changes will fulfill your suggestion.

  • comment out the matplotlib code( Someone might want to select the display area interactively).
  • remove the 6 MB File, and add 108Kb svg file (spectre tile(7.3, 12.7) 3-ITERATIONS 559-tiles).

@shrx
Copy link
Owner

shrx commented Feb 8, 2024

@reversi-fun let me know when you feel this is ready for review.

@reversi-fun
Copy link
Author

@reversi-fun let me know when you feel this is ready for review.
@shrx It's ready.
I hope review about this issure.
#3 (comment)

@shrx
Copy link
Owner

shrx commented Sep 10, 2025

Hi @reversi-fun I completely forgot about this project since I've been busy with other stuff. I see you've spent quite a lot of time working on the code improvements. If you just go through the proposed changes and remove the commented-out debugging code snippets and fix the spelling (e.g. "configlation", "drowsvg"), I think we can merge this.

@shrx
Copy link
Owner

shrx commented Dec 5, 2025

@brentharts I am very confused about what just happened. can you explain your commits to this pull request? it all looks completely unrelated to this repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants