Skip to content

Hot Reload Failure Test - New Instance Kill#1966

Draft
ric-pro wants to merge 9 commits intoshotover:mainfrom
ric-pro:test1
Draft

Hot Reload Failure Test - New Instance Kill#1966
ric-pro wants to merge 9 commits intoshotover:mainfrom
ric-pro:test1

Conversation

@ric-pro
Copy link
Contributor

@ric-pro ric-pro commented Dec 9, 2025

Tried to address the issue: #1962

The test following test passed:

  • perform a regular hot reload scenario
  • write variants of this test that kills the new shotover immediately after the new shotover emits these logs:
    • log for gradual shutdown
  • create a 3rd shotover instance with the same hot reload args as the first 2 instances.
  • assert that the 3rd instance successfully startsup.

But the following test failed:

  • perform a regular hot reload scenario
  • write variants of this test that kills the new shotover immediately after the new shotover emits these logs:
    • log for received FD's
  • create a 3rd shotover instance with the same hot reload args as the first 2 instances.
  • assert that the 3rd instance successfully startsup.

With the failed test, what I was trying to do was:

  1. Old shotover is running and serving connections
  2. New shotover starts and request for FD
  3. Old instance sends FD to new instance
  4. New Instance is killed before it receives the FD
    This will simulate a situation where an error occurs in between the hot reload process and the new shotover terminates. I was trying to test if a new shotover can be spinned up to cover for the termination of old shotover. The third instance will have same args as the first 2 instances. Ideally, the new shotover (third) should be able to take over from where the 2nd shotover terminated.

@codspeed-hq
Copy link

codspeed-hq bot commented Dec 9, 2025

CodSpeed Performance Report

Merging #1966 will not alter performance

Comparing ric-pro:test1 (c210d98) with main (2b6910b)

Summary

✅ 38 untouched

te28532
te28532 previously approved these changes Dec 9, 2025
@te28532 te28532 requested review from te28532 and removed request for te28532 December 9, 2025 02:15
@te28532 te28532 dismissed their stale review December 9, 2025 02:18

Was testing whether my account has approver rights in shotover

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants