Hot Reload Failure Test - New Instance Kill#1966
Draft
ric-pro wants to merge 9 commits intoshotover:mainfrom
Draft
Hot Reload Failure Test - New Instance Kill#1966ric-pro wants to merge 9 commits intoshotover:mainfrom
ric-pro wants to merge 9 commits intoshotover:mainfrom
Conversation
CodSpeed Performance ReportMerging #1966 will not alter performanceComparing Summary
|
te28532
previously approved these changes
Dec 9, 2025
Was testing whether my account has approver rights in shotover
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tried to address the issue: #1962
The test following test passed:
But the following test failed:
With the failed test, what I was trying to do was:
This will simulate a situation where an error occurs in between the hot reload process and the new shotover terminates. I was trying to test if a new shotover can be spinned up to cover for the termination of old shotover. The third instance will have same args as the first 2 instances. Ideally, the new shotover (third) should be able to take over from where the 2nd shotover terminated.