Skip to content

Make CI compatible with rustup 1.28#1875

Draft
rukai wants to merge 3 commits intoshotover:mainfrom
rukai:toolchain_install_for_rustup_1.28
Draft

Make CI compatible with rustup 1.28#1875
rukai wants to merge 3 commits intoshotover:mainfrom
rukai:toolchain_install_for_rustup_1.28

Conversation

@rukai
Copy link
Contributor

@rukai rukai commented Mar 3, 2025

As per the announcement: https://blog.rust-lang.org/2025/03/02/Rustup-1.28.0.html#whats-new-in-rustup-1280
There is a breaking change in rustup 1.28 and we must now manually run rustup toolchain install to replace the default toolchain with the toolchain specified in toolchain.toml

The announcement provides a way to remain compatible with both.
But I'll just wait for rustup 1.28 to arrive in github actions images to avoid the compatibility hack, since in the longterm its easier to understand.

@rukai rukai mentioned this pull request Mar 4, 2025
@rukai rukai force-pushed the toolchain_install_for_rustup_1.28 branch from a1f598a to 16082e9 Compare March 6, 2025 00:53
@rukai rukai force-pushed the toolchain_install_for_rustup_1.28 branch from 16082e9 to 4b4e95e Compare March 18, 2025 06:22
@codspeed-hq
Copy link

codspeed-hq bot commented Mar 18, 2025

CodSpeed Performance Report

Merging #1875 will not alter performance

Comparing rukai:toolchain_install_for_rustup_1.28 (274d8ba) with main (9c19111)

Summary

✅ 38 untouched benchmarks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant