Feature dom events #17
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Digest timer modified to use variable interval, either RAF or based on average execution time Moved callbacks to a handlers object within the status object. Added type protection to public methods. Updated getRoot method to return null when no root it present. Updated event names. Added limited recusion to the poll method, to detect changes during event dispatch.
Bound attributes in createElement and modifyElement to attach mutation events
added mutation events to the build scripts
added doc file for mutation events, content is currently event descriptions from custom elements v1 spec ( good starting point for descriptions )
Open
Owner
Author
|
@jcf120 review please? |
Collaborator
|
Sorry, hadn't been checking my emails. (Just moved to Taiwan.) I'll try and and find some time between work and Mandarin school haha. |
Owner
Author
|
Wow that's pretty awesome, hope it goes well for you! I'll try to press a little less on contribution, be nice to still see you helping out here and there though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added "connect" "disconnect" and "adopted" dom events API. Based on the spec from Custom Elements V1 but with it's own implementation based on polling.