Skip to content

Conversation

@louwers
Copy link
Contributor

@louwers louwers commented Nov 14, 2025

Replaces the screenshots of the Versatiles styles with an interactive viewer. This doesn't need to be updated like screenshots. I think it is also a lot more helpful to have an interactive map to explore than screenshots.

Screen.Recording.2025-11-14.at.21.37.16.mov

@pka pka merged commit 7436f41 into shortbread-tiles:main Nov 20, 2025
1 check passed
@pka
Copy link
Member

pka commented Nov 20, 2025

Thanks, Bart!

@joto
Copy link
Contributor

joto commented Nov 24, 2025

@pka This change would have needed some discussion. I am not happy with adding changes that include external javascript code (or any external ressources) for data protection issues and resilience of the web site.

@louwers
Copy link
Contributor Author

louwers commented Nov 24, 2025

data protection issues

I guess the worst that can happen is that the JavaScript defaces the entire website and turns it into a phishing site. But I find that extremely unlikely. It is a static documentation site, modern browsers have little if any cross origin data sharing, there's not really any data to protect, is there?

any external ressources

The website is already completely externally hosted (by GitHub).

resilience of the web site

When it comes to resilience, that is a fair point, jsDelivr could be down (although they have very good uptime) and Versatiles could be down. But I think the benefit of having an interactive map instead of just screenshots 99.9% of the time vastly outweighs the minimal downside here. And the link to Versatiles will continue working, so in a sense it is still has graceful degradation.

Just my 2 cents.

@pka
Copy link
Member

pka commented Nov 27, 2025

@joto is right, I forgot about our policy for vendored dependencies. shortbread-tiles.org ist hosted on a FOSSGIS e.V. server and we avoid external dependencies. Could you make a follow-up PR putting the jsdelivr.net resources into static/?

@louwers
Copy link
Contributor Author

louwers commented Nov 27, 2025

AH I thought it was GitHub Pages! Sure.

@joto @pka Is it OK to use Versatiles hosted styles? Or would those also be considered external resources?

@joto
Copy link
Contributor

joto commented Nov 28, 2025

We should have everything hosted locally. Including styles, fonts, icons, etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants