docs: fix app signature verification php header name and secret name #2044
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes incorrect documentation in the app signature verification guide for signing responses from app servers back to Shopware. The documentation previously showed the wrong variable and header name for response signatures.
Key changes:
- Corrected the secret used for signing responses from
$appSecretto$shopSecret(the shop-specific secret generated during registration) - Fixed the response header name from
shopware-shop-signaturetoshopware-app-signature
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
lernhart
approved these changes
Dec 17, 2025
Contributor
|
Thx for the PR @skyracer2012 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. Why is this change necessary?
The current documenatation for https://developer.shopware.com/docs/guides/plugins/apps/app-signature-verification.html#signing-responses are wrong.
2. What does this change do, exactly?
In reality the header is named "shopware-app-signature" and it is not the app secret that is used but the, in the handshake generated, shop secret