Skip to content

Conversation

@jozsefdamokos
Copy link
Member

Fixed some errors + some helpful additions in custom document type page

@jozsefdamokos jozsefdamokos self-assigned this Dec 10, 2025
@jozsefdamokos jozsefdamokos requested review from a team and sushmangupta December 10, 2025 12:34
Copy link
Contributor

@Isengo1989 Isengo1989 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx for the PR @jozsefdamokos 🎉

@ennasus4sun
Copy link

one more thing:
I had a look into the other existing page right now (Add Custom Document). I did not test it, but I think it is not adding a new document. Looks more like adding a custom config (in the example for delivery-notes) for a specific sales-channel 🤔 (I assume that's the same we can do in the admin already).
But ... it sounds like we create a new document type.
Maybe this can be written more clear by using the word "document config" instead document.

AND:
maybe also our real new document (DocumentRenderer) will need a new config after we added it (just an assumption)

@jozsefdamokos
Copy link
Member Author

jozsefdamokos commented Dec 12, 2025

@ennasus4sun the other page (Add Custom Document) is correct, it adds a new document in the list of documents in the admin. It is the same you can do in the admin but this one is via the migration (for when your plugin should create a document on plugin install for example). The naming is a bit confusing, but the article says: "Documents in Shopware are stored in the database table document_base_config. Do not confuse it with the document table, which contains the actually generated documents"

@Isengo1989 Isengo1989 merged commit ee0840c into main Dec 15, 2025
7 of 8 checks passed
@Isengo1989 Isengo1989 deleted the fix/custom-document-type branch December 15, 2025 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants