Update Actor pattern documentation to include a11y-poc functionality #2022
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Isengo1989
requested review from
Isengo1989 and
Copilot
and removed request for
Isengo1989
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the Actor pattern documentation to reflect new accessibility functionality added to the acceptance test suite in PR #410. The documentation now includes comprehensive guidance on using accessibility-focused methods for keyboard navigation and focus verification, which align with WCAG requirements.
Key changes:
- Added new "Accessibility Methods" section documenting
a11y_checks,presses,fillsIn, andselectsRadioButtonmethods - Updated existing code examples to demonstrate accessibility methods instead of direct Playwright methods
- Added extensive new examples showing PageObject, Task, and test scenario implementations using the new accessibility methods
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Isengo1989
requested changes
Dec 2, 2025
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
sushmangupta
requested changes
Dec 3, 2025
sushmangupta
approved these changes
Dec 3, 2025
Contributor
|
Thanks for the PR @ravenokko :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have updated the acceptance test suite to include additional support for accessibility with shopware/acceptance-test-suite#410. This updates the Actor pattern page details to include the new methods available.