Skip to content

test: ErrorIs should support having both err and target be nil #177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shoenig merged 1 commit into from
Feb 26, 2025
Merged

test: ErrorIs should support having both err and target be nil #177

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion internal/assertions/assertions.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,7 +164,7 @@ func EqError(err error, msg string) (s string) {
}

func ErrorIs(err error, target error) (s string) {
if err == nil {
if err == nil && target != nil {
s = "expected non-nil error; got nil\n"
return
}
Expand Down
4 changes: 4 additions & 0 deletions must/must_test.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 4 additions & 0 deletions test_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,6 +163,10 @@ func TestErrorIs_nil(t *testing.T) {
ErrorIs(tc, nil, err)
}

func TestErrorIs_nil_nil(t *testing.T) {
ErrorIs(t, nil, nil)
}

type FakeError string

func (e FakeError) Error() string {
Expand Down