fix: do not throw on empty resource files#11
Open
emazv72 wants to merge 1 commit intoshlomiassaf:masterfrom
Open
fix: do not throw on empty resource files#11emazv72 wants to merge 1 commit intoshlomiassaf:masterfrom
emazv72 wants to merge 1 commit intoshlomiassaf:masterfrom
Conversation
|
A huge +1 on this, because it caused the errors for me as well, but VSCode's terminal did not dropped an error for me just frozed for good. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If a component references an empty resource file (styleUrls)
npm run lib:buildthrows an error while inlining.This typically happens when you generate a component with angular-cli like this:
ng generate componentThe css generated for the component is empty.
angular-cli can handle empty resource files and doesn't throw.
This PR tries to fix the issue.