Skip to content

fix: do not throw on empty resource files#11

Open
emazv72 wants to merge 1 commit intoshlomiassaf:masterfrom
emazv72:master
Open

fix: do not throw on empty resource files#11
emazv72 wants to merge 1 commit intoshlomiassaf:masterfrom
emazv72:master

Conversation

@emazv72
Copy link

@emazv72 emazv72 commented Jul 5, 2017

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

If a component references an empty resource file (styleUrls) npm run lib:build throws an error while inlining.

  • What is the current behavior? (You can also link to an open issue here)

This typically happens when you generate a component with angular-cli like this:

ng generate component

The css generated for the component is empty.
angular-cli can handle empty resource files and doesn't throw.

  • What is the new behavior (if this is a feature change)?

This PR tries to fix the issue.

  • Other information:

@monutam91
Copy link

monutam91 commented Jul 20, 2017

A huge +1 on this, because it caused the errors for me as well, but VSCode's terminal did not dropped an error for me just frozed for good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants