Guard against division by zero in progress speed calculation#141
Merged
madebydavid merged 2 commits into138-feature-some-progress-indication-of-the-upload-progress-in-default-ship-mode-and-follow-ship-modefrom Jan 22, 2026
Conversation
Co-authored-by: madebydavid <5401249+madebydavid@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Address feedback on progress tracking logic
Guard against division by zero in progress speed calculation
Jan 22, 2026
madebydavid
approved these changes
Jan 22, 2026
d084d52
into
138-feature-some-progress-indication-of-the-upload-progress-in-default-ship-mode-and-follow-ship-mode
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses potential division by zero when calculating transfer speed in progress tracking callbacks. When operations complete in <1ms,
elapsedSecondscan be 0, resulting inInfinityforspeedMBps.Changes:
zip.tsandupload.tsto return0whenelapsedSeconds < 0.001Speed displays as "0.00 MB/s" initially, then updates to actual rate as data transfers.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.