Added announcements module and configuration#6
Added announcements module and configuration#6Hardik-hi wants to merge 15 commits intoshiksha-platform:mainfrom
Conversation
modules/announcements/src/App.tsx
Outdated
| function App() { | ||
| const routes: RouteProps[] = [ | ||
| { | ||
| path: "/", |
There was a problem hiding this comment.
The URLs that will be seen in the browser should be
/announcements
/announcements/create
/announcements/edit/:id
There was a problem hiding this comment.
this module is not yet used in console app. the these routes are only used when app runs as standalone.
the urls are
https://sandbox.shikshaplatform.io/modules/announcements/...
There was a problem hiding this comment.
Got it. Do update the routes anyway @Hardik-hi and also ensure appropriate routes are used when this module is imported into the parent admin ui app.
| @@ -0,0 +1,13 @@ | |||
| body { | |||
There was a problem hiding this comment.
Is the CSS necessary, does it not import the CSS from the parent app ?
cc @arajput
There was a problem hiding this comment.
this is default file by CRA. it is used only when module runs as stand alone.
Hardik-hi
force-pushed
the
features/announcement
branch
from
8804ce5 to
4f349e1
Compare
This comment was marked as resolved.
This comment was marked as resolved.
Hardik-hi
force-pushed
the
features/announcement
branch
from
0988013 to
1d00b46
Compare
Hardik-hi
force-pushed
the
features/announcement
branch
from
1d00b46 to
86911ab
Compare
3 participants
Changes
cc: @coolbung