forked from ExpediaGroup/beekeeper
-
Notifications
You must be signed in to change notification settings - Fork 0
get /tables endpoint #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
shermosa
wants to merge
117
commits into
api
Choose a base branch
from
egdl-2015
base: api
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
117 commits
Select commit
Hold shift + click to select a range
4b555de
changes
c813679
removing useless stuff
866dc7f
tidy up
2a3a633
remove unused imports
56d8697
adding classes
21c2dce
clean up
17c38c0
idk
afb6bbc
metastore
5e28ddd
space
486bc1a
fixing service classes
32aa4a8
sabe tables
e5f2bcc
test class
34cc340
works
62cfc65
remove mthod
0099efc
value
8b5dc9a
adding classes
41d94d1
delete file
b1299a1
classes
cd461c5
override
d73afe5
pages
77ddf10
wrong import
50881e3
fixing test class
e19796f
table name
0b04c31
adding controller test class
b3a8ae6
controller test class does not work
36e4cac
pom
20d82d4
changes
13b5e52
renaming modules
20fc86b
renaming variables
f7693e9
generating dummy data class
021d949
fixing test class
eed7b84
renaming method
c378940
adding verification mocks
3dea0bf
impl class
72fca3f
add filtering in controller
a325002
adding specs
8a865ec
idk
4796fea
doesn't work
e6cbe4e
idk whats going on
9294f26
Fix
810ba01
Merge branch 'egdl-2015' of https://github.com/shermosa/beekeeper int…
baed7ed
stuff
11931c8
stuff
bc0dbd1
works without the mockmvc and verifications
61e123e
reproducing error
dc173f3
reproducing error
598edba
still doesn't work, utf8 error
896e506
compiles correctly without test
3cc729f
compiles fine
8de5070
compiles fine
b17cb11
ACTUALLY compiles correctyl
c424e7c
reproducing error
500df9b
some of it works
226642a
improvement
dc7a449
mysqlutils
b9f0e69
i think i fixed it
6afbab8
taking out dependencies and systemoutprintln
ecd6378
compiles correctly/checked
ba321db
taking out jetty redundant exlcusions
420f91b
renaming variables
c36d6ad
taking out useless exclusions
83b906c
tidy up
877dea2
tidy up
3239029
relocating TestApplication class
6f83af6
renaming class names
637b22d
adding test for filtering
9d6c5e6
test for wrong url
baf6ea8
test for paging
c972dc7
adding api integration test class
e3a903a
ading beforeeach and aftereach methods
e7eb6fb
trying to run integration tests
3711af0
renaming
b1f0958
reproducing error
f9b0bd9
works
b806e8d
doesnt work
cdc8d65
works,two test written
d565a5e
works forreal
0975cb9
cleaning up
ccc4376
adding tests, works
f87c3c0
database filtering test done
cb9fd43
adding test for housekeeping filter works
350fadc
add test for lifecycleeventtyoe
1a3cfd2
adding lombok
ac1e806
dummy data
0b49bbf
reproducing error
3be3297
reproducing error
79a1df0
fixed prob
474c60f
IJ doesn't recognise class
d68c84a
error
001d6a3
compiles correctly after finished lombok
a5e4681
this fixes intellij error but should be removed later
b4864a7
weird error
18a5409
works
b5031d3
tests work
1dc01f8
correcting tests
e520e19
timestamp cleanup work
3b5468c
tofy up
75c040d
deleted after test
570bc41
1 more test
a4c453a
added 1 more test
0f4b1fa
tidy up
2e2e8e2
500 error
14ca76c
Revert "500 error"
98dd452
creating response classes
f7efe76
adding classes
dae91e6
path service has an error
b46252a
making a return object
e32c151
return object
08a3155
fixing folder name
4b1e9eb
tests fail
a55f363
adding new servic
0532a42
adding
43cfbd6
currently adds lifecycles together correclty but doesnt delete duplik…
5abfc4e
almost works, need to make sure theyre different lifecycles
caeb296
packing tables together works
15b7162
tidy up
9bbad7e
i dont know whats here
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -11,6 +11,10 @@ | |
|
|
||
| <artifactId>beekeeper-api</artifactId> | ||
|
|
||
| <properties> | ||
| <specification-arg-resolver.version>2.6.1</specification-arg-resolver.version> | ||
| </properties> | ||
|
|
||
| <dependencies> | ||
| <dependency> | ||
| <groupId>org.springframework.boot</groupId> | ||
|
|
@@ -20,6 +24,36 @@ | |
| <groupId>org.springframework.boot</groupId> | ||
| <artifactId>spring-boot-actuator</artifactId> | ||
| </dependency> | ||
| <dependency> | ||
| <groupId>com.expediagroup</groupId> | ||
| <artifactId>beekeeper-core</artifactId> | ||
| <version>${project.version}</version> | ||
| </dependency> | ||
| <dependency> | ||
| <groupId>net.kaczmarzyk</groupId> | ||
| <artifactId>specification-arg-resolver</artifactId> | ||
| <version>${specification-arg-resolver.version}</version> | ||
| </dependency> | ||
| <dependency> | ||
| <groupId>org.json</groupId> | ||
| <artifactId>json</artifactId> | ||
| <version>20080701</version> | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Is this what resolved your JSON dependency issue?
Owner
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. yas queen |
||
| </dependency> | ||
|
|
||
| <!-- test --> | ||
| <dependency> | ||
shermosa marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| <groupId>org.springframework.boot</groupId> | ||
| <artifactId>spring-boot-starter-test</artifactId> | ||
| <scope>test</scope> | ||
| </dependency> | ||
| <dependency> | ||
| <groupId>org.projectlombok</groupId> | ||
| <artifactId>lombok</artifactId> | ||
| </dependency> | ||
| <dependency> | ||
| <groupId>org.projectlombok</groupId> | ||
| <artifactId>lombok</artifactId> | ||
| </dependency> | ||
| </dependencies> | ||
|
|
||
| </project> | ||
52 changes: 52 additions & 0 deletions
52
beekeeper-api/src/main/java/com/expediagroup/beekeeper/api/BeekeeperApiApplication.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,52 @@ | ||
| /** | ||
| * Copyright (C) 2019-2021 Expedia, Inc. | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
| package com.expediagroup.beekeeper.api; | ||
|
|
||
| import javax.annotation.PostConstruct; | ||
|
|
||
| import org.springframework.beans.factory.annotation.Autowired; | ||
| import org.springframework.boot.SpringApplication; | ||
| import org.springframework.boot.autoconfigure.SpringBootApplication; | ||
| import org.springframework.boot.autoconfigure.domain.EntityScan; | ||
| import org.springframework.boot.context.properties.EnableConfigurationProperties; | ||
| import org.springframework.context.annotation.ComponentScan; | ||
| import org.springframework.data.jpa.repository.config.EnableJpaRepositories; | ||
|
|
||
| import com.fasterxml.jackson.databind.ObjectMapper; | ||
| import com.fasterxml.jackson.datatype.jsr310.JavaTimeModule; | ||
|
|
||
| @SpringBootApplication | ||
| @EnableConfigurationProperties | ||
| @EntityScan(basePackages = { "com.expediagroup.beekeeper.core.model" }) | ||
| @EnableJpaRepositories(basePackages = { "com.expediagroup.beekeeper.core.repository" }) | ||
| @ComponentScan(basePackages = { | ||
| "com.expediagroup.beekeeper.api.conf", | ||
| "com.expediagroup.beekeeper.api.controller", | ||
| "com.expediagroup.beekeeper.api.service" }) | ||
| public class BeekeeperApiApplication { | ||
|
|
||
| @Autowired | ||
| private ObjectMapper objectMapper; | ||
|
|
||
| public static void main(String[] args) { | ||
| SpringApplication.run(BeekeeperApiApplication.class, args); | ||
| } | ||
|
|
||
| @PostConstruct | ||
| public void setUp() { | ||
| objectMapper.registerModule(new JavaTimeModule()); | ||
| } | ||
| } |
35 changes: 35 additions & 0 deletions
35
beekeeper-api/src/main/java/com/expediagroup/beekeeper/api/conf/JPAConfiguration.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,35 @@ | ||
| /** | ||
| * Copyright (C) 2019-2021 Expedia, Inc. | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
| package com.expediagroup.beekeeper.api.conf; | ||
|
|
||
| import java.util.List; | ||
|
|
||
| import org.springframework.context.annotation.Configuration; | ||
| import org.springframework.data.jpa.repository.config.EnableJpaRepositories; | ||
| import org.springframework.web.method.support.HandlerMethodArgumentResolver; | ||
| import org.springframework.web.servlet.config.annotation.WebMvcConfigurer; | ||
|
|
||
| import net.kaczmarzyk.spring.data.jpa.web.SpecificationArgumentResolver; | ||
|
|
||
| @Configuration | ||
| @EnableJpaRepositories | ||
| public class JPAConfiguration implements WebMvcConfigurer { | ||
|
|
||
| @Override | ||
| public void addArgumentResolvers(List<HandlerMethodArgumentResolver> argumentResolvers) { | ||
| argumentResolvers.add(new SpecificationArgumentResolver()); | ||
| } | ||
| } |
70 changes: 70 additions & 0 deletions
70
...eper-api/src/main/java/com/expediagroup/beekeeper/api/controller/BeekeeperController.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,70 @@ | ||
| /** | ||
| * Copyright (C) 2019-2021 Expedia, Inc. | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
| package com.expediagroup.beekeeper.api.controller; | ||
|
|
||
|
|
||
| import static org.springframework.http.MediaType.APPLICATION_JSON_VALUE; | ||
|
|
||
| import static com.expediagroup.beekeeper.api.response.HousekeepingMetadataResponse.convertToHouseKeepingMetadataResponsePage; | ||
|
|
||
| import org.springframework.beans.factory.annotation.Autowired; | ||
| import org.springframework.data.domain.Page; | ||
| import org.springframework.data.domain.Pageable; | ||
| import org.springframework.data.jpa.domain.Specification; | ||
| import org.springframework.http.ResponseEntity; | ||
| import org.springframework.web.bind.annotation.GetMapping; | ||
| import org.springframework.web.bind.annotation.RequestMapping; | ||
| import org.springframework.web.bind.annotation.RestController; | ||
|
|
||
| import net.kaczmarzyk.spring.data.jpa.domain.EqualIgnoreCase; | ||
| import net.kaczmarzyk.spring.data.jpa.domain.GreaterThan; | ||
| import net.kaczmarzyk.spring.data.jpa.domain.LessThan; | ||
| import net.kaczmarzyk.spring.data.jpa.web.annotation.And; | ||
| import net.kaczmarzyk.spring.data.jpa.web.annotation.Spec; | ||
|
|
||
| import com.expediagroup.beekeeper.api.response.HousekeepingMetadataResponse; | ||
| import com.expediagroup.beekeeper.api.service.BeekeeperService; | ||
| import com.expediagroup.beekeeper.api.service.HousekeepingMetadataService; | ||
| import com.expediagroup.beekeeper.core.model.HousekeepingMetadata; | ||
|
|
||
| @RequestMapping("/api/v1") | ||
| @RestController | ||
| public class BeekeeperController { | ||
| private final BeekeeperService beekeeperService; | ||
|
|
||
| @Autowired | ||
| public BeekeeperController(HousekeepingMetadataService housekeepingMetadataService, | ||
| BeekeeperService beekeeperService) { | ||
| this.beekeeperService = beekeeperService; | ||
| } | ||
|
|
||
| @GetMapping(path = "/tables", produces = APPLICATION_JSON_VALUE) | ||
| public ResponseEntity<Page<HousekeepingMetadataResponse>> getAll( | ||
| @And({ | ||
| @Spec(path = "tableName", params = "table_name", spec = EqualIgnoreCase.class), | ||
| @Spec(path = "databaseName", params = "database_name", spec = EqualIgnoreCase.class), | ||
| @Spec(path = "housekeepingStatus", params = "housekeeping_status", spec = EqualIgnoreCase.class), | ||
| @Spec(path = "lifecycleType", params = "lifecycle_type", spec = EqualIgnoreCase.class), | ||
| @Spec(path = "cleanupTimestamp", params = "deleted_before", spec = LessThan.class), | ||
| @Spec(path = "cleanupTimestamp", params = "deleted_after", spec = GreaterThan.class), | ||
| @Spec(path = "creationTimestamp", params = "registered_before", spec = LessThan.class), | ||
| @Spec(path = "creationTimestamp", params = "registered_after", spec = GreaterThan.class) | ||
| }) | ||
| Specification<HousekeepingMetadata> spec, Pageable pageable) { | ||
| return ResponseEntity.ok(beekeeperService.getAllTables(spec, pageable)); | ||
| } | ||
|
|
||
| } |
103 changes: 103 additions & 0 deletions
103
...i/src/main/java/com/expediagroup/beekeeper/api/response/HousekeepingMetadataResponse.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,103 @@ | ||
| package com.expediagroup.beekeeper.api.response; | ||
|
|
||
| import java.util.ArrayList; | ||
| import java.util.List; | ||
| import java.util.Map; | ||
|
|
||
| import javax.persistence.Column; | ||
| import javax.persistence.Table; | ||
|
|
||
| import org.springframework.data.domain.Page; | ||
| import org.springframework.data.domain.PageImpl; | ||
|
|
||
| import lombok.Builder; | ||
| import lombok.Value; | ||
|
|
||
| import com.expediagroup.beekeeper.core.model.HousekeepingMetadata; | ||
|
|
||
| @Value | ||
| @Builder | ||
| @Table(name = "housekeeping_metadata") | ||
| public class HousekeepingMetadataResponse { | ||
|
|
||
| @Column(name = "database_name", nullable = false) | ||
| String databaseName; | ||
|
|
||
| @Column(name = "table_name", nullable = false) | ||
| String tableName; | ||
|
|
||
| @Column(name = "path", nullable = false) | ||
| String path; | ||
|
|
||
| @Column(name = "lifecycles", nullable = false) | ||
| List<Lifecycle> lifecycles; | ||
|
|
||
| public static HousekeepingMetadataResponse convertToHouseKeepingMetadataResponse( | ||
| HousekeepingMetadata housekeepingMetadata) { | ||
| List<Lifecycle> lifecyclesList = new ArrayList<>(); | ||
| Lifecycle lifecycle = Lifecycle.builder() | ||
| .lifecycleEventType(housekeepingMetadata.getLifecycleType()) | ||
| .configuration(Map.of( | ||
| "beekeeper.unreferenced.data.retention.period",housekeepingMetadata.getCleanupDelay().toString(), | ||
| "clean up timestamp", housekeepingMetadata.getCleanupTimestamp().toString() | ||
| )) | ||
| .build() | ||
| ; | ||
| lifecyclesList.add(lifecycle); | ||
|
|
||
| return HousekeepingMetadataResponse.builder() | ||
| .databaseName(housekeepingMetadata.getDatabaseName()) | ||
| .tableName(housekeepingMetadata.getTableName()) | ||
| .path(housekeepingMetadata.getPath()) | ||
| .lifecycles(lifecyclesList) | ||
| .build(); | ||
| } | ||
|
|
||
| public static Page<HousekeepingMetadataResponse> convertToHouseKeepingMetadataResponsePage(List<HousekeepingMetadata> housekeepingMetadataList){ | ||
| List<HousekeepingMetadataResponse> housekeepingMetadataResponseList = new ArrayList<>(); | ||
| for (HousekeepingMetadata housekeepingMetadata : housekeepingMetadataList) { | ||
| HousekeepingMetadataResponse housekeepingMetadataResponse = convertToHouseKeepingMetadataResponse(housekeepingMetadata); | ||
| int repeatedTablePosition = checkIfTableExists(housekeepingMetadataResponseList, housekeepingMetadata); | ||
|
|
||
| if(repeatedTablePosition!=-1){ | ||
| housekeepingMetadataResponse = housekeepingMetadataResponseList.get(repeatedTablePosition); | ||
| housekeepingMetadataResponseList.remove(repeatedTablePosition); | ||
| Lifecycle lifecycle = Lifecycle.builder() | ||
| .lifecycleEventType(housekeepingMetadata.getLifecycleType()) | ||
| .configuration(Map.of( | ||
| "beekeeper.unreferenced.data.retention.period",housekeepingMetadata.getCleanupDelay().toString(), | ||
| "clean up timestamp", housekeepingMetadata.getCleanupTimestamp().toString() | ||
| )) | ||
| .build(); | ||
| housekeepingMetadataResponse.addLifecycle(lifecycle); | ||
| } | ||
|
|
||
| housekeepingMetadataResponseList.add(housekeepingMetadataResponse); | ||
| } | ||
| return new PageImpl<>(housekeepingMetadataResponseList); | ||
| } | ||
|
|
||
| public static int checkIfTableExists( | ||
| List<HousekeepingMetadataResponse> housekeepingMetadataResponseList, HousekeepingMetadata housekeepingMetadata){ | ||
| int count = -1; | ||
| int positionOfRepeatedTable = -1; | ||
| String tableName1 = housekeepingMetadata.getTableName(); | ||
| String databaseName1 = housekeepingMetadata.getDatabaseName(); | ||
| if(!housekeepingMetadataResponseList.isEmpty()) { | ||
| for (HousekeepingMetadataResponse table : housekeepingMetadataResponseList) { | ||
| count++; | ||
| String tableName2 = table.getTableName(); | ||
| String databaseName2 = table.getDatabaseName(); | ||
| if (tableName1.equals(tableName2) && databaseName1.equals(databaseName2)) { | ||
| positionOfRepeatedTable = count; | ||
| } | ||
| } | ||
| } | ||
| return positionOfRepeatedTable; | ||
| } | ||
|
|
||
| public void addLifecycle(Lifecycle lifecycle){ | ||
| lifecycles.add(lifecycle); | ||
| } | ||
|
|
||
| } |
17 changes: 17 additions & 0 deletions
17
beekeeper-api/src/main/java/com/expediagroup/beekeeper/api/response/Lifecycle.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| package com.expediagroup.beekeeper.api.response; | ||
|
|
||
| import java.util.Map; | ||
|
|
||
| import lombok.Builder; | ||
| import lombok.Value; | ||
|
|
||
| @Value | ||
| @Builder | ||
| public class Lifecycle { | ||
|
|
||
| String lifecycleEventType; | ||
| Map<String, String> configuration; | ||
|
|
||
|
|
||
|
|
||
| } |
26 changes: 26 additions & 0 deletions
26
beekeeper-api/src/main/java/com/expediagroup/beekeeper/api/service/BeekeeperService.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,26 @@ | ||
| package com.expediagroup.beekeeper.api.service; | ||
|
|
||
| import static com.expediagroup.beekeeper.api.response.HousekeepingMetadataResponse.convertToHouseKeepingMetadataResponsePage; | ||
|
|
||
| import org.springframework.beans.factory.annotation.Autowired; | ||
| import org.springframework.data.domain.Page; | ||
| import org.springframework.data.domain.Pageable; | ||
| import org.springframework.data.jpa.domain.Specification; | ||
| import org.springframework.stereotype.Service; | ||
|
|
||
| import com.expediagroup.beekeeper.api.response.HousekeepingMetadataResponse; | ||
| import com.expediagroup.beekeeper.core.model.HousekeepingMetadata; | ||
|
|
||
| @Service | ||
| public class BeekeeperService { | ||
|
|
||
| private final HousekeepingMetadataService housekeepingMetadataService; | ||
|
|
||
| @Autowired | ||
| public BeekeeperService( | ||
| HousekeepingMetadataService housekeepingMetadataService) {this.housekeepingMetadataService = housekeepingMetadataService;} | ||
|
|
||
| public Page<HousekeepingMetadataResponse> getAllTables(Specification<HousekeepingMetadata> spec, Pageable pageable) { | ||
| return convertToHouseKeepingMetadataResponsePage(housekeepingMetadataService.getAll(spec, pageable).getContent()); | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.