feat: Add default export for CommonJS/ESM compatibility #170
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Thanks for you pr, but ci is failed, and I just fix this myself. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces a default export to the velocity.js library. This change enhances compatibility with environments that expect a default export when using ECMAScript Module (ESM) import syntax (import ... from ...).
Motivation:
Currently, velocity.js primarily exports its functionalities (render, parse, Compile, Helper) as named exports using CommonJS (module.exports). While this works well in CommonJS environments, it causes issues in ESM contexts where a default export is expected for the import ... from ... syntax.