Visualize Critics for SAC and PPO #22
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment: last_values doesn't seem to have much of an impact on performance at all. However, for off-policy algorithms, having access to the next state (obs) explicitly starts to be a lot handier. Alternative is to do some data juggling to pull it out, which is a bit tedious and probably needs to be stored in a tensor anyway to allow the batch generation
Does not train, need to tune.
- data was not being added correctly - runner was indexing along num_envs instead of time - use data getter to handle overfill
Runner burnin
Unify SAC branches
sheim
reviewed
Jun 19, 2024
sheim
reviewed
Jun 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue ticket number and link
Fixes # (issue)
Describe your changes
Please include a summary of the change, including why you did this, and the desired effect.
Instructions for reviewers
Indicate anything in particular that you would like a code-reviewer to pay particular attention to.
Indicate steps to actually test code, including CLI instructions if different than usual.
Point out the desired behavior, and not just the "check that this appears" (otherwise the code reviewer will be lazy and just verify what you've already verified).
Checklist before requesting a review
ruff format .manually