-
-
Notifications
You must be signed in to change notification settings - Fork 1
style: format code with Google Java Format #63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
This commit fixes the style issues introduced in 40f234f according to the output from Google Java Format. Details: None
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, we are unable to review this pull request
The GitHub API does not allow us to fetch diffs exceeding 20000 lines
|
Important Review skippedBot user detected. To trigger a single review, invoke the You can disable this status message by setting the Comment |
|
Here's the code health analysis summary for commits Analysis Summary
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Important
Looks good to me! 👍
Reviewed everything up to 81bf876 in 3 minutes and 0 seconds. Click for details.
- Reviewed
37671lines of code in133files - Skipped
0files when reviewing. - Skipped posting
9draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. Overall:1
- Draft comment:
This pull request reformats the entire codebase using Google Java Format. The changes appear to be purely stylistic, ensuring consistent indentation, spacing, and import ordering. No functional, logical, performance, or security issues were introduced. Good job! - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%None
2. app/src/main/java/io/github/sheepdestroyer/materialisheep/AdBlocker.java:89
- Draft comment:
Typo: In the comment, "sub domain" should be "subdomain" for consistency and correctness. - Reason this comment was not posted:
Comment was on unchanged code.
3. app/src/main/java/io/github/sheepdestroyer/materialisheep/BaseFragment.java:52
- Draft comment:
Typo: In the comment, "restored in to the view" should be "restored into the view". - Reason this comment was not posted:
Comment was on unchanged code.
4. app/src/main/java/io/github/sheepdestroyer/materialisheep/ListFragment.java:203
- Draft comment:
Typo: It looks like 'setHotThresHold' might be intended to be 'setHotThreshold'. Please confirm if this is a naming error. - Reason this comment was not posted:
Comment was on unchanged code.
5. app/src/main/java/io/github/sheepdestroyer/materialisheep/Preferences.java:718
- Draft comment:
Typo: Consider renaming the parameter 'isTransulcent' to 'isTranslucent' to fix the spelling. - Reason this comment was not posted:
Comment was on unchanged code.
6. app/src/main/java/io/github/sheepdestroyer/materialisheep/UserActivity.java:61
- Draft comment:
Typographical note: The variable name 'mItemManger' appears to be a typo. It likely should be 'mItemManager'. - Reason this comment was not posted:
Comment was on unchanged code.
7. app/src/main/java/io/github/sheepdestroyer/materialisheep/appwidget/WidgetRefreshJobService.java:26
- Draft comment:
Typo: Consider replacing the abbreviation 'conn' with the full word 'connection' for clarity in the comment. - Reason this comment was not posted:
Comment was on unchanged code.
8. app/src/main/java/io/github/sheepdestroyer/materialisheep/widget/AsteriskSpan.java:45
- Draft comment:
Typo detected: In the comment after Math.round, "padding let" appears to be a typo and should likely be "padding left". - Reason this comment was not posted:
Comment was on unchanged code.
9. app/src/main/java/io/github/sheepdestroyer/materialisheep/widget/ListRecyclerViewAdapter.java:148
- Draft comment:
Typo: The method name 'setHotThresHold' (and its parameter 'hotThresHold') appears to be misspelled. Consider renaming it to 'setHotThreshold' for consistency with the field name 'mHotThreshold'. - Reason this comment was not posted:
Comment was on unchanged code.
Workflow ID: wflow_7zxTMcRH3mTxnjYi
You can customize by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.
This commit fixes the style issues introduced in 40f234f according to the output
from Google Java Format.
Details: None
Important
Apply Google Java Format to multiple Java files for consistent styling.
ApplicationComponent.java,ComposeActivity.java, andItemActivity.java.NetworkModule.java,SettingsActivity.java, andUserActivity.java.This description was created by
for 81bf876. You can customize this summary. It will automatically update as commits are pushed.