Skip to content

handle external dependencies #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
YoussefACHCHIRAJ merged 1 commit into from
Nov 5, 2025
Merged

handle external dependencies #45

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions src/Traits/CanHandleDependenciesInstallation.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,9 +155,10 @@ public function installExternalDeps(array $deps)
}

$this->command->info(" ↳ Installing $name External Dependencies");
foreach ($deps as $key => $dep) {
$this->command->info(" <fg=white>Installing</fg=white> <bg=green, fg=white>$key</bg=green,>...");
Process::run($dep[1]);
foreach ($deps as $dep) {
$name = key($dep);
$this->command->info(" <fg=white>Installing</fg=white> <bg=green>$name</bg=green>...");
Process::run($dep[$name]);
}
}

Expand Down
2 changes: 1 addition & 1 deletion tests/Feature/Commands/RemoveCommandTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@
});


it("Removes an installed component along with its dependencies when removal is confirmed.", function () {
it("Removes an installed component along with its dependencies when removal is confirmed. update test descriptions for component removal scenarios", function () {

$component = 'autocomplete';
$dependency = 'icon';
Expand Down