Implement binary support for ios as well#1
Open
kevinmershon wants to merge 12 commits intoshblythe:masterfrom
Open
Implement binary support for ios as well#1kevinmershon wants to merge 12 commits intoshblythe:masterfrom
kevinmershon wants to merge 12 commits intoshblythe:masterfrom
Conversation
added 12 commits
April 23, 2015 19:38
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This featureset does a couple of interesting things that may not be obvious:
window.atobon invocation of the Javascript to decode, ensuring we can pass true binary data back.Be sure to view the pull request with
?w=1appended to the URL (to ignore whitespace changes).